Article cover federation #304

New issue

Closed

opened 2018-11-04 16:39:13 +00:00 by trinity-1686a · 1 comment

trinity-1686a commented

2018-11-04 16:39:13 +00:00

Owner

There seems to be an issue with article cover federation. The remote instance seems to know there is a picture, but it don't know what it is.
Example:

Inplume-models/src/medias.rs from_activity() copy the image locally, and save it with remote_url: None, however it set is_remote to true, where url() expect is_remote to be true only if it needs to return remote_url, and false when the picture is stored locally, and the url has to be computed.

Plume version (and/or commit): 8d5eaaec6a

There seems to be an issue with article cover federation. The remote instance seems to know there is a picture, but it don't know what it is. Example: - [original article](https://fediverse.blog/~/ChristOffLecture/e-mc2-l'équation-de-tous-les-possibles-de-christophe-galfard/) - [federated view on another instance](https://baptiste.gelez.xyz/~/ChristOffLecture@fediverse.blog/e-mc2-l'%C3%A9quation-de-tous-les-possibles-de-christophe-galfard/) In`plume-models/src/medias.rs` `from_activity()` copy the image locally, and save it with `remote_url: None`, however it set `is_remote` to true, where `url()` expect `is_remote` to be true only if it needs to return `remote_url`, and false when the picture is stored locally, and the url has to be computed. Plume version (and/or commit): 8d5eaaec6acb69c4e157bf8c75358fa71f944c62

👍 1

trinity-1686a commented

2018-12-02 18:13:38 +00:00

Author

Owner

closed by ed71d24fe9

closed by ed71d24fe9bb66244474c87959c07dd422baeb14