Upgrade plume dependencies #332

Merged
Plume_migration_agent merged 28 commits from master into master 5 years ago
Owner

Not much changed, I just changed some code because of validator 0.8.0 breaking changes, and removed hyper from plume-common dependencies as it was somehow unnecessary

Not much changed, I just changed some code because of validator 0.8.0 breaking changes, and removed hyper from plume-common dependencies as it was somehow unnecessary
codecov[bot] commented 5 years ago (Migrated from github.com)

Codecov Report

Merging #332 into master will decrease coverage by 2%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
- Coverage   30.24%   28.23%   -2.01%     
==========================================
  Files          62       62              
  Lines        5221     5592     +371     
==========================================
  Hits         1579     1579              
- Misses       3642     4013     +371
Impacted Files Coverage Δ
src/main.rs 0% <ø> (ø) ⬆️
plume-common/src/lib.rs 100% <ø> (ø) ⬆️
src/routes/session.rs 0% <0%> (ø) ⬆️
src/routes/blogs.rs 0% <0%> (ø) ⬆️
src/routes/posts.rs 0% <0%> (ø) ⬆️
src/routes/user.rs 0% <0%> (ø) ⬆️
src/routes/instance.rs 0% <0%> (ø) ⬆️
plume-models/src/posts.rs 12.29% <0%> (-0.03%) ⬇️
src/routes/comments.rs 0% <0%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4e4b49...f1ef082. Read the comment docs.

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/332?src=pr&el=h1) Report > Merging [#332](https://codecov.io/gh/Plume-org/Plume/pull/332?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/b4e4b497eee2fe661295ff5b2000cae98dddd8e6?src=pr&el=desc) will **decrease** coverage by `2%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/Plume-org/Plume/pull/332/graphs/tree.svg?width=650&token=sHtxmDuZ06&height=150&src=pr)](https://codecov.io/gh/Plume-org/Plume/pull/332?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #332 +/- ## ========================================== - Coverage 30.24% 28.23% -2.01% ========================================== Files 62 62 Lines 5221 5592 +371 ========================================== Hits 1579 1579 - Misses 3642 4013 +371 ``` | [Impacted Files](https://codecov.io/gh/Plume-org/Plume/pull/332?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/main.rs](https://codecov.io/gh/Plume-org/Plume/pull/332/diff?src=pr&el=tree#diff-c3JjL21haW4ucnM=) | `0% <ø> (ø)` | :arrow_up: | | [plume-common/src/lib.rs](https://codecov.io/gh/Plume-org/Plume/pull/332/diff?src=pr&el=tree#diff-cGx1bWUtY29tbW9uL3NyYy9saWIucnM=) | `100% <ø> (ø)` | :arrow_up: | | [src/routes/session.rs](https://codecov.io/gh/Plume-org/Plume/pull/332/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcy9zZXNzaW9uLnJz) | `0% <0%> (ø)` | :arrow_up: | | [src/routes/blogs.rs](https://codecov.io/gh/Plume-org/Plume/pull/332/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcy9ibG9ncy5ycw==) | `0% <0%> (ø)` | :arrow_up: | | [src/routes/posts.rs](https://codecov.io/gh/Plume-org/Plume/pull/332/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcy9wb3N0cy5ycw==) | `0% <0%> (ø)` | :arrow_up: | | [src/routes/user.rs](https://codecov.io/gh/Plume-org/Plume/pull/332/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcy91c2VyLnJz) | `0% <0%> (ø)` | :arrow_up: | | [src/routes/instance.rs](https://codecov.io/gh/Plume-org/Plume/pull/332/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcy9pbnN0YW5jZS5ycw==) | `0% <0%> (ø)` | :arrow_up: | | [plume-models/src/posts.rs](https://codecov.io/gh/Plume-org/Plume/pull/332/diff?src=pr&el=tree#diff-cGx1bWUtbW9kZWxzL3NyYy9wb3N0cy5ycw==) | `12.29% <0%> (-0.03%)` | :arrow_down: | | [src/routes/comments.rs](https://codecov.io/gh/Plume-org/Plume/pull/332/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcy9jb21tZW50cy5ycw==) | `0% <0%> (ø)` | :arrow_up: | | ... and [15 more](https://codecov.io/gh/Plume-org/Plume/pull/332/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/Plume-org/Plume/pull/332?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/332?src=pr&el=footer). Last update [b4e4b49...f1ef082](https://codecov.io/gh/Plume-org/Plume/pull/332?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
elegaanz (Migrated from github.com) reviewed 5 years ago
elegaanz (Migrated from github.com) commented 5 years ago

I think we don't need rpassword anymore in Plume itself (only in the CLI), maybe we should remove it with this PR too?

I think we don't need rpassword anymore in Plume itself (only in the CLI), maybe we should remove it with this PR too?
trinity-1686a reviewed 5 years ago
Poster
Owner

I did it for hyper, there is no reason to not do it for rpassword too

I did it for hyper, there is no reason to not do it for rpassword too
elegaanz (Migrated from github.com) reviewed 5 years ago
elegaanz (Migrated from github.com) left a comment

Thanks.

Thanks.
elegaanz (Migrated from github.com) approved these changes 5 years ago
elegaanz (Migrated from github.com) left a comment

Seems good. If everything is here, you can merge.

Seems good. If everything is here, you can merge.
Poster
Owner

rocket 0.4.0 is missing but require upgrading compiler to nightly-2018-11-24

rocket 0.4.0 is missing but require upgrading compiler to `nightly-2018-11-24`
elegaanz commented 5 years ago (Migrated from github.com)

If you want to update it, it's not a problem to update Rust too IMHO. Otherwise, we'll do it in a separated PR.

If you want to update it, it's not a problem to update Rust too IMHO. Otherwise, we'll do it in a separated PR.
Poster
Owner

I'm just checking everything is fine, but compiling with a new rustc require to rebuild all dependencies

I'm just checking everything is fine, but compiling with a new rustc require to rebuild all dependencies

Reviewers

The pull request has been merged as e1ecc7289f.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b master master
git pull origin master

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff master
git push origin master
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#332
Loading…
There is no content yet.