License federation #343

Merged

elegaanz merged 2 commits from license-federation into master

2018-12-09 17:43:35 +00:00

elegaanz commented

2018-12-09 14:05:06 +00:00

(Migrated from github.com)

Fixes #259

I decided not to follow what Peertube was doing, and to use a simple license field with the name of the license, because their system is not flexible enough IMO, each AP implementation would have to keep the same list of licenses, and it wouldn't allow any other license outside of that.

A bit unrelated, but I also made it possible to have no specific license to keep all your rights on what you wrote. The license field will now be pre-filled with the default license when creating a post, and emptying it will display "All rights reserved" instead of the name of the license.

Fixes #259 I decided not to follow what Peertube was doing, and to use a simple `license` field with the name of the license, because their system is not flexible enough IMO, each AP implementation would have to keep the same list of licenses, and it wouldn't allow any other license outside of that. A bit unrelated, but I also made it possible to have no specific license to keep all your rights on what you wrote. The license field will now be pre-filled with the default license when creating a post, and emptying it will display "All rights reserved" instead of the name of the license.

👍 1

codecov[bot] commented

2018-12-09 14:23:19 +00:00

(Migrated from github.com)

Codecov Report

Merging #343 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
- Coverage   28.23%   28.22%   -0.02%     
==========================================
  Files          62       62              
  Lines        5592     5595       +3     
==========================================
  Hits         1579     1579              
- Misses       4013     4016       +3

Impacted Files	Coverage Δ
src/routes/user.rs	`0% <0%> (ø)`	⬆️
plume-models/src/posts.rs	`12.14% <0%> (-0.16%)`	⬇️
plume-common/src/activity_pub/mod.rs	`4.25% <0%> (-0.1%)`	⬇️
src/routes/posts.rs	`0% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9f2f76...21f8c91. Read the comment docs.

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/343?src=pr&el=h1) Report > Merging [#343](https://codecov.io/gh/Plume-org/Plume/pull/343?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/e9f2f769bed326bed5c537bd97527419df02d20d?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/Plume-org/Plume/pull/343/graphs/tree.svg?width=650&token=sHtxmDuZ06&height=150&src=pr)](https://codecov.io/gh/Plume-org/Plume/pull/343?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #343 +/- ## ========================================== - Coverage 28.23% 28.22% -0.02% ========================================== Files 62 62 Lines 5592 5595 +3 ========================================== Hits 1579 1579 - Misses 4013 4016 +3 ``` | [Impacted Files](https://codecov.io/gh/Plume-org/Plume/pull/343?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/routes/user.rs](https://codecov.io/gh/Plume-org/Plume/pull/343/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcy91c2VyLnJz) | `0% <0%> (ø)` | :arrow_up: | | [plume-models/src/posts.rs](https://codecov.io/gh/Plume-org/Plume/pull/343/diff?src=pr&el=tree#diff-cGx1bWUtbW9kZWxzL3NyYy9wb3N0cy5ycw==) | `12.14% <0%> (-0.16%)` | :arrow_down: | | [plume-common/src/activity\_pub/mod.rs](https://codecov.io/gh/Plume-org/Plume/pull/343/diff?src=pr&el=tree#diff-cGx1bWUtY29tbW9uL3NyYy9hY3Rpdml0eV9wdWIvbW9kLnJz) | `4.25% <0%> (-0.1%)` | :arrow_down: | | [src/routes/posts.rs](https://codecov.io/gh/Plume-org/Plume/pull/343/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcy9wb3N0cy5ycw==) | `0% <0%> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/Plume-org/Plume/pull/343?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/343?src=pr&el=footer). Last update [e9f2f76...21f8c91](https://codecov.io/gh/Plume-org/Plume/pull/343?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

trinity-1686a approved these changes 2018-12-09 16:05:54 +00:00

trinity-1686a left a comment

Owner

elegaanz commented

2018-12-09 16:37:12 +00:00

(Migrated from github.com)

What if we .unwrap_or(instance_default_license) here: https://github.com/Plume-org/Plume/pull/343/files#diff-1b633efbc0716f65e55e3170eb127764R796 ? Maybe this behavior would be better? Or is it worse?

What if we `.unwrap_or(instance_default_license)` here: https://github.com/Plume-org/Plume/pull/343/files#diff-1b633efbc0716f65e55e3170eb127764R796 ? Maybe this behavior would be better? Or is it worse?

trinity-1686a commented

2018-12-09 16:46:50 +00:00

Owner

I don't know, saying all right reserved is maybe more conservative. Telling peoples "this is CC-BY-SA" when it should be all right reserved seems to me like a bigger problem than the opposite, "all right reserved" might be false but at least it won't induce people into violating licenses involuntarily. Like most of the time when you simply have not enough information, no solution is perfect 😐

👍 1

No reviewers

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#343

No description provided.