New Issue

Use serial_test #469

Open

opened by elegaanz · 6 comments

elegaanz commented (Migrated from github.com)

This crate allows you to run some test one after the other. By using it we could make sure database tests are always run serially (without even needing to set RUST_TEST_THREADS=1), and other tests can still run concurrently.

Plume version (and/or commit): 0.2.0

[This crate](https://github.com/palfrey/serial_test) allows you to run some test one after the other. By using it we could make sure database tests are always run serially (without even needing to set `RUST_TEST_THREADS=1`), and other tests can still run concurrently. Plume version (and/or commit): 0.2.0

igalic commented (Migrated from github.com)

why are our database tests not parallelizable?
fixing that issue would be a better solution than cheating on the database tests

why are our database tests not parallelizable? fixing that issue would be a better solution than cheating on the database tests

elegaanz commented (Migrated from github.com)

I agree, and I don't remember the details… 😅 maybe @fdb-hiroshima knows, since she is the one who wrote most of these tests.

I agree, and I don't remember the details… :sweat_smile: maybe @fdb-hiroshima knows, since she is the one who wrote most of these tests.

trinity-1686a commented

Owner

I have no idea, running theme in parallel on my computer (or anything other than Travis really) works fine, but for some reasons, it did not work at all on Travis, one random test was passing, and all others failed

elegaanz commented (Migrated from github.com)

Ah, they don't work concurrently on my computer either… Really weird 🤷‍♀️

Ah, they don't work concurrently on my computer either… Really weird :woman_shrugging:

igalic commented (Migrated from github.com)

so, when looking into deploying Plume, please consider doing it on @fdb-hiroshima's machine, but not on Travis (docker!) or on @BaptisteGelez's machine.

😆 2

trinity-1686a commented

Owner

(Plume is using virtual machines from GCE, not docker containers when building on Travis)

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.

Labels Milestones

Use serial_test #469