Correct some grammar in the english text #508

Closed
marek-lach wants to merge 90 commits from Correct-some-grammar-in-the-English-text into master
marek-lach commented 5 years ago (Migrated from github.com)

Hope I didn't forget anything :-)

  • Also corrects some translations, where they're translations of a different source string than needed

Now resolved by #510

Hope I didn't forget anything :-) - Also corrects some translations, where they're translations of a different source string than needed Now resolved by #510
elegaanz commented 5 years ago (Migrated from github.com)

Wow, thank you so much for all that. I just need to check it (but I trust you, it should be good) and to update the templates too before merging.

Edit: and I'll try to fix the build too, because it looks like it is failing.

Wow, thank you so much for all that. I just need to check it (but I trust you, it should be good) and to update the templates too before merging. Edit: and I'll try to fix the build too, because it looks like it is failing.
marek-lach commented 5 years ago (Migrated from github.com)

I'll try to fix the build too, because it looks like it is failing.

Hm... yes it does, I'll try to check where the problem could be.

Edit: There's a difference of one line in pl.pot, as seen bellow:

Screenshot 2019-03-31 at 20 41 18

I didn't think that matters, but maybe it does, who knows?

> I'll try to fix the build too, because it looks like it is failing. Hm... yes it does, I'll try to check where the problem could be. Edit: There's a difference of one line in pl.pot, as seen bellow: <img width="1277" alt="Screenshot 2019-03-31 at 20 41 18" src="https://user-images.githubusercontent.com/45913977/55293406-9b0ea800-53f6-11e9-8118-6739e213998a.png"> I didn't think that matters, but maybe it does, who knows?
elegaanz (Migrated from github.com) reviewed 5 years ago
@ -39,3 +39,3 @@
# src/routes/blogs.rs:70
msgid "You need to be logged in order to create a new blog"
msgid "To create a new blog, you need to be logged in"
msgstr ""
elegaanz (Migrated from github.com) commented 5 years ago

I thought these messages have already been corrected, but looks like they haven't… 🤔

I thought these messages have already been corrected, but looks like they haven't… :thinking:
elegaanz commented 5 years ago (Migrated from github.com)

Edit: There's a difference of one line in pl.pot, as seen bellow:

Screenshot 2019-03-31 at 20 41 18

I didn't think that matters, but maybe it does, who knows?

No, I don't think it changes anything.

Also for next time you want to update a lot of messages like that: edit them directly in the templates files, I can then copy your branch a generate all the
.po/.pot automatically.

> Edit: There's a difference of one line in pl.pot, as seen bellow: > > <img alt="Screenshot 2019-03-31 at 20 41 18" width="1277" src="https://user-images.githubusercontent.com/45913977/55293406-9b0ea800-53f6-11e9-8118-6739e213998a.png"> > > I didn't think that matters, but maybe it does, who knows? No, I don't think it changes anything. Also for next time you want to update a lot of messages like that: edit them directly in the `templates` files, I can then copy your branch a generate all the `.po`/`.pot` automatically.
marek-lach (Migrated from github.com) reviewed 5 years ago
@ -39,3 +39,3 @@
# src/routes/blogs.rs:70
msgid "You need to be logged in order to create a new blog"
msgid "To create a new blog, you need to be logged in"
msgstr ""
marek-lach (Migrated from github.com) commented 5 years ago

I did correct it in Crowndin some time back, though not to this level, and it's always better to do it at the source level... :)

I did correct it in Crowndin some time back, though not to this level, and it's always better to do it at the source level... :)
marek-lach commented 5 years ago (Migrated from github.com)

Also for next time you want to update a lot of messages like that: edit them directly in the templates files, I can then copy your branch a generate all the
.po/.pot automatically.

I have now done this. If possible, you can exclude my .po files of individual languages from this merge, and rebuild them anew based on the string changes I made in templates.

Hopefully the build could then pass that way :-)
I've made a separate PR #510 for that, so closing this issue now.

> Also for next time you want to update a lot of messages like that: edit them directly in the `templates` files, I can then copy your branch a generate all the > `.po`/`.pot` automatically. I have now done this. If possible, you can exclude my .po files of individual languages from this merge, and rebuild them anew based on the string changes I made in templates. Hopefully the build could then pass that way :-) I've made a separate PR #510 for that, so closing this issue now.
This pull request cannot be reopened because the branch was deleted.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b Correct-some-grammar-in-the-English-text master
git pull origin Correct-some-grammar-in-the-English-text

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff Correct-some-grammar-in-the-English-text
git push origin master
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#508
Loading…
There is no content yet.