remove the new index lock tantivy uses #556

Merged

Plume_migration_agent merged 1 commits from tantivy-unlock into master

trinity-1686a commented

Owner

There is no content yet.

codecov[bot] commented (Migrated from github.com)

Codecov Report

Merging #556 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
- Coverage   44.67%   44.66%   -0.02%     
==========================================
  Files          70       70              
  Lines        7989     7991       +2     
==========================================
  Hits         3569     3569              
- Misses       4420     4422       +2

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/556?src=pr&el=h1) Report > Merging [#556](https://codecov.io/gh/Plume-org/Plume/pull/556?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/49bb8cb0bc2a5e9164b2931b1ba799b4434c68a1?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #556 +/- ## ========================================== - Coverage 44.67% 44.66% -0.02% ========================================== Files 70 70 Lines 7989 7991 +2 ========================================== Hits 3569 3569 - Misses 4420 4422 +2 ```

elegaanz (Migrated from github.com) approved these changes

fulmicoton commented (Migrated from github.com)

Sorry for chiming in a bit late. In recent version, tantivy uses bsd locks. You don't need to remove those files at all. If your process die, restarting should work just fine.

trinity-1686a commented

Poster

Owner

I've noticed it while trying my changes, but actually one user managed to have it's index locked while no plume was running, I've no idea how. Anyway it's here in case it happen, and hopefully it does not

Reviewers

The pull request has been merged as 18ae6e26b3.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b tantivy-unlock master

git pull origin tantivy-unlock

Step 2:

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff tantivy-unlock

git push origin master

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…