don't discard error when failing to read .env #629

New issue

Closed

opened 2019-07-02 06:06:30 +00:00 by trinity-1686a · 0 comments

trinity-1686a commented

2019-07-02 06:06:30 +00:00

Owner

Is your feature request related to a problem? Please describe.
Currently we try to open .env, and if it fails we assume one did not want to configure their instance that way. This is very unhelpful when the error is not from a missing file but any other kind of error that can happen (and looking at the return type, there are many)

Describe the solution you'd like
On error, get the actual error, log it, and if it is file not found, ignore it. On success, log from where the config was read (it can be read from any parent directory)

~~Describe alternatives you've considered~~

Additional context
supersede #626

**Is your feature request related to a problem? Please describe.** Currently we try to open .env, and if it fails we assume one did not want to configure their instance that way. This is very unhelpful when the error is not from a missing file but any other kind of error that can happen (and looking at the return type, there are many) **Describe the solution you'd like** On error, get the actual error, log it, and if it is file not found, ignore it. On success, log from where the config was read (it can be read from any parent directory) ~~**Describe alternatives you've considered**~~ **Additional context** supersede #626

👍 1

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#629

No description provided.

Rows
Columns