snap: Ensure cargo-web doesn't erroneously adopt our workspace. #667

Merged
RAOF merged 1 commits from fix-snapcraft-build into master 5 years ago
RAOF commented 5 years ago (Migrated from github.com)

Because snapcraft pulls the source into a subdirectory of Plume's source, and
Cargo will implicitly and recursively search parent directories for a [Workspace],
Cargo believes that cargo-web should be in Plume's workspace.

However, Cargo then errors out because Plume's [Workspace] stanza (entirely correctly)
doens't mention cargo-web.

Adding an empty [Workspace] stanza to cargo-web's Cargo.toml disables Cargo's implicit
search for a workspace to adopt, and avoids this problem.

Because snapcraft pulls the source into a subdirectory of Plume's source, and Cargo will implicitly and recursively search parent directories for a [Workspace], Cargo believes that cargo-web should be in Plume's workspace. However, Cargo then errors out because Plume's [Workspace] stanza (entirely correctly) doens't mention cargo-web. Adding an empty [Workspace] stanza to cargo-web's Cargo.toml disables Cargo's implicit search for a workspace to adopt, and avoids this problem.
trinity-1686a approved these changes 5 years ago
trinity-1686a left a comment
Owner

👍
(ci error is about uploading to plume-ci for live testing, not required here)

👍 (ci error is about uploading to plume-ci for live testing, not required here)

Reviewers

trinity-1686a approved these changes 5 years ago
The pull request has been merged as b36e12b654.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b fix-snapcraft-build master
git pull origin fix-snapcraft-build

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff fix-snapcraft-build
git push origin master
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#667
Loading…
There is no content yet.