Upgrade Tantivy to v0.12.0 #771

Merged

KitaitiMakoto merged 5 commits from upgrade-tantivy into master

KitaitiMakoto commented (Migrated from github.com)

Hi,

I upgraded Tantivy to v0.12.0 because I want to introduce Japanese full-text search feature via lindera-tantivy, which requires Tantivy v0.12.0.

Hi, I upgraded Tantivy to v0.12.0 because I want to introduce Japanese full-text search feature via [lindera-tantivy][], which requires Tantivy v0.12.0. [lindera-tantivy]: https://github.com/lindera-morphology/lindera-tantivy

👍 2

codecov[bot] commented (Migrated from github.com)

Codecov Report

Merging #771 into master will increase coverage by 0.11%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master     #771      +/-   ##
==========================================
+ Coverage   38.95%   39.07%   +0.11%     
==========================================
  Files          73       73              
  Lines        9729     9735       +6     
  Branches     2227     2227              
==========================================
+ Hits         3790     3804      +14     
+ Misses       4885     4879       -6     
+ Partials     1054     1052       -2

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/771?src=pr&el=h1) Report > Merging [#771](https://codecov.io/gh/Plume-org/Plume/pull/771?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/3be842c6536c7c7df54d93c4db0c9e5662a0001b&el=desc) will **increase** coverage by `0.11%`. > The diff coverage is `93.75%`. ```diff @@ Coverage Diff @@ ## master #771 +/- ## ========================================== + Coverage 38.95% 39.07% +0.11% ========================================== Files 73 73 Lines 9729 9735 +6 Branches 2227 2227 ========================================== + Hits 3790 3804 +14 + Misses 4885 4879 -6 + Partials 1054 1052 -2 ```

igalic (Migrated from github.com) approved these changes

igalic (Migrated from github.com) left a comment

approving this, since the code seems to look good

but i'd rather @fdb-hiroshima take a look, or if you could add tests that prove what you done works. for now. and hopefully for the future.

approving this, since the code seems to look good but i'd rather @fdb-hiroshima take a look, or if you could add tests that prove what you done works. for now. and hopefully for the future.

KitaitiMakoto commented (Migrated from github.com)

when rebasing, do i just skip this commit?
or do i need to do something special here?

To be honest, I don't know because I'm not familiar with Rust async. But I guess you need some work with this code at least calling .await and so on.

> when rebasing, do i just skip this commit? or do i need to do something special here? To be honest, I don't know because I'm not familiar with Rust async. But I guess you need some work with this code at least calling `.await` and so on.

trinity-1686a commented

Owner

I haven't looked at Tantivy for months but that looks in adequacy with changes that where on tantivy's issue tracker at that time 👍

I haven't looked at Tantivy for months but that looks in adequacy with changes that where on tantivy's issue tracker at that time :+1:

KitaitiMakoto commented (Migrated from github.com)

Thank you!

kiwii referenced this issue from a commit

Upgrade Tantivy to v0.12.0 (#771) * Upgrade Tantivy to 0.12.0 * Follow Tantivy Tokenizer's new type definition * Wrap tokenizers with TextAnalyzer to use filter methods * Replace async IndexWriter::garbage_collect_files with sync functions * Update Cargo.toml

Reviewers

The pull request has been merged as ef70cb93e6.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b upgrade-tantivy master

git pull origin upgrade-tantivy

Step 2:

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff upgrade-tantivy

git push origin master

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.

Labels Milestones

Upgrade Tantivy to v0.12.0 #771

Codecov Report

Reviewers

Step 1:

Step 2: