Plume
/
Plume
5
11
Fork 10
Code Issues 141 Pull Requests 12 Releases 5 Wiki Activity
Labels Milestones
New Issue

#882 After commit callback

Open
opened 2 months ago by KitaitiMakoto · 2 comments
KitaitiMakoto commented 2 months ago

Think you

  1. begin transaction
  2. insert a post
  3. publishes PostPublished event to the actor channel
  4. some error occurs
  5. transaction rollbacked
  6. but you can find the post by search

We should publish PostPublished only after transaction commited.

Solusion might include sending patches to diesel.

Think you 1. begin transaction 2. insert a post 3. publishes `PostPublished` event to the actor channel 4. some error occurs 5. transaction rollbacked 6. but you can find the post by search We should publish `PostPublished` only after transaction commited. Solusion might include sending patches to diesel.
KitaitiMakoto commented 2 months ago
Owner

Currently, we don’t use transactions. There’s no problem.

Currently, we don't use transactions. There's no problem.
KitaitiMakoto commented 1 month ago
Owner

It might be good to move database-related code from request handlers to models.

It might be good to move database-related code from request handlers to models.
KitaitiMakoto added the
A: Backend
label 2 weeks ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Apply labels
Clear labels
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes