Plume/Plume
9
18
Fork 24
Code Issues 177 Pull requests 8 Releases 8 Wiki Activity

Don't strip shipped binaries #929

New issue
Closed
opened 2021-05-25 13:11:53 +00:00 by trinity-1686a · 0 comments
trinity-1686a commented 2021-05-25 13:11:53 +00:00
Owner
Copy link

Currently we strip binaries so they are smaller. This remove debugging symbols which are apparently used when generating backtraces. Without them, a typical backtrace looks like this:

stack backtrace:
   0:     0x5615348edf74 - <unknown>
   1:     0x561534910e5c - <unknown>
[21 lines omitted]
  23:     0x5615348df7ef - <unknown>
  24:     0x5615348f6110 - <unknown>
  25:     0x7fc5d9984609 - start_thread
  26:     0x7fc5d988e293 - __clone
  27:                0x0 - <unknown>

This makes it way harder to understand the issue, as we have no idea where the panic was emited

Currently we strip binaries so they are smaller. This remove debugging symbols which are apparently used when generating backtraces. Without them, a typical backtrace looks like this: ``` stack backtrace: 0: 0x5615348edf74 - <unknown> 1: 0x561534910e5c - <unknown> [21 lines omitted] 23: 0x5615348df7ef - <unknown> 24: 0x5615348f6110 - <unknown> 25: 0x7fc5d9984609 - start_thread 26: 0x7fc5d988e293 - __clone 27: 0x0 - <unknown> ``` This makes it way harder to understand the issue, as we have no idea where the panic was emited
👍 1
trinity-1686a added the
C: Enhancement
Build
 labels 2021-05-25 13:12:28 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1686a/resist-gone-sender
1686a/fast-fill
paginate-search-init
s3
fix-delete-user
timeline-cli
blog-title
signature
remove-dup-images
ldap-non-anon
drone-ci
DearRude/force-lang
igalic/go/async-all-mut
go/async
floreal/translations-update
missing-docs
RAOF/fix-arm64-build
epsilon-phase/authorized-fetch
upgrade
improve-the-editor-once-again
igalic/feat/custom-fairing-domains
feature/ldap
test/dotenv_error
fix-mobile-margin
0.7.2
0.7.1
0.7.0
0.6.0
0.5.0
0.4.0-alpha-4
0.3.0-alpha-2
0.2.0-alpha-1
Labels
Clear labels   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

No labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#929
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?