Plume
/
Plume
5
12
Fork 12
Code Issues 152 Pull Requests 11 Releases 5 Wiki Activity
Labels Milestones
New Issue

Don't strip shipped binaries #929

Open
opened 2 months ago by trinity-1686a · 0 comments
trinity-1686a commented 2 months ago
Owner

Currently we strip binaries so they are smaller. This remove debugging symbols which are apparently used when generating backtraces. Without them, a typical backtrace looks like this:

stack backtrace:
   0:     0x5615348edf74 - <unknown>
   1:     0x561534910e5c - <unknown>
[21 lines omitted]
  23:     0x5615348df7ef - <unknown>
  24:     0x5615348f6110 - <unknown>
  25:     0x7fc5d9984609 - start_thread
  26:     0x7fc5d988e293 - __clone
  27:                0x0 - <unknown>

This makes it way harder to understand the issue, as we have no idea where the panic was emited

Currently we strip binaries so they are smaller. This remove debugging symbols which are apparently used when generating backtraces. Without them, a typical backtrace looks like this: ``` stack backtrace: 0: 0x5615348edf74 - <unknown> 1: 0x561534910e5c - <unknown> [21 lines omitted] 23: 0x5615348df7ef - <unknown> 24: 0x5615348f6110 - <unknown> 25: 0x7fc5d9984609 - start_thread 26: 0x7fc5d988e293 - __clone 27: 0x0 - <unknown> ``` This makes it way harder to understand the issue, as we have no idea where the panic was emited
trinity-1686a added the
C: Enhancement
Build
 labels 2 months ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
DearRude/force-lang
RAOF/fix-arm64-build
better-caching
bidi-md
clippy
dir-safestring
drone-ci
epsilon-phase/authorized-fetch
feature/ldap
fix-mobile-margin
floreal/translations-update
gh-pr-818
go/async
igalic/feat/custom-fairing-domains
igalic/fix/cargo-release-helper
igalic/go/async-all-mut
ignore-journal
improve-the-editor-once-again
ldap-non-anon
main
master
missing-docs
remove-dup-images
test/dotenv_error
upgrade
v0.7.0
Labels
Apply labels
Clear labels
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
No Label A: API A: Backend A: Federation A: Front-End A: I18N A: Meta A: Security Build C: Bug C: Discussion C: Enhancement C: Feature Compatibility Dependency Design Documentation Good first issue Help welcome Mobile Rendering S: Blocked S: Duplicate S: Incomplete S: Instance specific S: Invalid S: Needs Voting/Discussion S: Ready for review Suggestion S: Voted on Loomio S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes