SMTP server port configuration #944

New issue

Closed

opened 2021-09-02 21:52:35 +00:00 by KitaitiMakoto · 3 comments

KitaitiMakoto commented

2021-09-02 21:52:35 +00:00

Owner

Some cloud vendors block port (25 and) 465.

Marius commented

2021-12-09 11:55:00 +00:00

For that issue, we can add a new environment variable: MAIL_PORT.

Then we add a new helper, based on https://docs.rs/lettre/0.9.6/src/lettre/smtp/mod.rs.html#133-144:

fn new_simple_with_port(domain: &str, port: u16) -> Result<SmtpClient, Error> {
        //Original code from lettre
        let mut tls_builder = TlsConnector::builder();
        tls_builder.min_protocol_version(Some(DEFAULT_TLS_PROTOCOLS[0]));

        let tls_parameters =
            ClientTlsParameters::new(domain.to_string(), tls_builder.build().unwrap());

        SmtpClient::new(
        	//Modified for configuration
            (domain, port),
            //Original code
            ClientSecurity::Wrapper(tls_parameters),
        )
    }

And then our code (https://git.joinplu.me/Plume/Plume/src/branch/main/src/mail.rs#L66) become:

let smtp_port = env::var("MAIL_PORT").ok()?;
let mail = SmtpClient::new_simple_with_port(domain,smtp_port)

But maybe this is more an issue of lettre than plume ?

For that issue, we can add a new *environment variable*: **MAIL_PORT**. Then we add a new helper, based on https://docs.rs/lettre/0.9.6/src/lettre/smtp/mod.rs.html#133-144: ```rust fn new_simple_with_port(domain: &str, port: u16) -> Result<SmtpClient, Error> { //Original code from lettre let mut tls_builder = TlsConnector::builder(); tls_builder.min_protocol_version(Some(DEFAULT_TLS_PROTOCOLS[0])); let tls_parameters = ClientTlsParameters::new(domain.to_string(), tls_builder.build().unwrap()); SmtpClient::new( //Modified for configuration (domain, port), //Original code ClientSecurity::Wrapper(tls_parameters), ) } ``` And then our code (https://git.joinplu.me/Plume/Plume/src/branch/main/src/mail.rs#L66) become: ```rust let smtp_port = env::var("MAIL_PORT").ok()?; let mail = SmtpClient::new_simple_with_port(domain,smtp_port) ``` But maybe this is more an issue of **lettre** than **plume** ?

👍 1

KitaitiMakoto commented

2021-12-12 05:49:57 +00:00

Author

Owner

Good investigation! Let's add the env var and modify Plume code.