Blocking of instances does not work

KitaitiMakoto commented

2021-12-17 15:55:42 +00:00

Owner

https://matrix.to/#/!GadivaCUefoxxyyVFt:matrix.org/$UwmvostC5D3pLPxanVNnMaQaOlx-EETo3Q6aZnUCl0I?via=matrix.org&via=tchncs.de&via=cooperteam.net

Jakob
blocking of instances does not work...
i have blocked several instances with suspect content or russian fonts and content which are flooding my federating timeline.

but i get all day new content from this blocked instances...

https://matrix.to/#/!GadivaCUefoxxyyVFt:matrix.org/$UwmvostC5D3pLPxanVNnMaQaOlx-EETo3Q6aZnUCl0I?via=matrix.org&via=tchncs.de&via=cooperteam.net > Jakob blocking of instances does not work... i have blocked several instances with suspect content or russian fonts and content which are flooding my federating timeline. > > but i get all day new content from this blocked instances...

KitaitiMakoto added the

C: Bug

label 2022-01-02 17:10:06 +00:00

KitaitiMakoto commented

2022-01-08 12:09:30 +00:00

Author

Owner

I started to investigate this issue. But I could not reproduce it in may local machine. Can you set debug logging and check it?

At first, add this line to your .env file:

RUST_LOG=debug,html5ever=warn,hyper=warn,tantivy=warn

and restart Plume. Then you can see lines like below when someone in the issue posted an article:

2022-01-08T11:55:00.268705Z  INFO _: Matched: POST /inbox (shared_inbox) 
(snip)
2022-01-08T11:55:00.359653Z DEBUG reqwest::async_impl::response: Response: '200 OK' for https://plume02.localhost/~/Plume02Blog/plume02-blog-article-2022-01-08-07/

Those mean Plume accept notification that an article is published.

If '200 OK' line appears, domain blocking doesn't work. Compare the domain you block and appears in the log line. If '200 OK' line doesn't appear, the article was blocked.

Can you check it out whether the domains are the same? If they are, a bug seems there. More investigation is needed.

I started to investigate this issue. But I could not reproduce it in may local machine. Can you set debug logging and check it? At first, add this line to your `.env` file: RUST_LOG=debug,html5ever=warn,hyper=warn,tantivy=warn and restart Plume. Then you can see lines like below when someone in the issue posted an article: 2022-01-08T11:55:00.268705Z INFO _: Matched: POST /inbox (shared_inbox) (snip) 2022-01-08T11:55:00.359653Z DEBUG reqwest::async_impl::response: Response: '200 OK' for https://plume02.localhost/~/Plume02Blog/plume02-blog-article-2022-01-08-07/ Those mean Plume accept notification that an article is published. If '200 OK' line appears, domain blocking doesn't work. Compare the domain you block and appears in the log line. If '200 OK' line doesn't appear, the article was blocked. Can you check it out whether the domains are the same? If they are, a bug seems there. More investigation is needed.

milan commented

2022-01-08 22:57:39 +00:00

Yes, i can confirm logentries like in your example.

KitaitiMakoto commented

2022-01-08 23:02:50 +00:00

Author

Owner

@milan Thank you for confirmation. Are the domain you block at admin panel and appearing in the log line same?

And can you tell me the version of Plume you run?

@milan Thank you for confirmation. Are the domain you block at admin panel and appearing in the log line same? And can you tell me the version of Plume you run?

milan commented

2022-01-09 16:56:34 +00:00

Not sure why i've tried to block it in the past, maybe for test reasons (and your news bot is very annoying, but i am aware that also interesting/important people are there... please add remote user blocks), but let's go with fediverse.blog...

Not sure why you mean by "the same", the it displays all addresses without https://,

Blocking posts

^[[2mJan 09 17:47:55.337^[[0m ^[[32m INFO^[[0m rocket::rocket: POST /admin/instances/3/block application/x-www-form-urlencoded:
^[[2mJan 09 17:47:55.337^[[0m ^[[32m INFO^[[0m _: Matched: POST /admin/instances/<id>/block (toggle_block)
^[[2mJan 09 17:47:55.342^[[0m ^[[32m INFO^[[0m _: Outcome: Success
^[[2mJan 09 17:47:55.342^[[0m ^[[32m INFO^[[0m _: Response succeeded.

plume=> select * from instances where id=3;
 id | public_domain  |      name      | local | blocked |       creation_date        | open_registrations | short_description | long_description | default_license | long_description_html | short_description_html 
----+----------------+----------------+-------+---------+----------------------------+--------------------+-------------------+------------------+-----------------+-----------------------+------------------------
  3 | fediverse.blog | fediverse.blog | f     | t       | 2020-06-17 12:26:09.404793 | t                  |                   |                  |                 |                       | 
(1 row)

I am not sure how much of the log from processing posts/outboxes is in context or even interesting.... .

I've installed Plume from Git on tags/0.7.0. It's https://write.tchncs.de if this helps in any way, now that we both discovered that it involves an instance under your control. ;)

Not sure why i've tried to block it in the past, maybe for test reasons (and your news bot is very annoying, but i am aware that also interesting/important people are there... please add remote user blocks), but let's go with fediverse.blog... Not sure why you mean by "the same", the it displays all addresses without https://, Blocking posts ``` ^[[2mJan 09 17:47:55.337^[[0m ^[[32m INFO^[[0m rocket::rocket: POST /admin/instances/3/block application/x-www-form-urlencoded: ^[[2mJan 09 17:47:55.337^[[0m ^[[32m INFO^[[0m _: Matched: POST /admin/instances/<id>/block (toggle_block) ^[[2mJan 09 17:47:55.342^[[0m ^[[32m INFO^[[0m _: Outcome: Success ^[[2mJan 09 17:47:55.342^[[0m ^[[32m INFO^[[0m _: Response succeeded. ``` ``` plume=> select * from instances where id=3; id | public_domain | name | local | blocked | creation_date | open_registrations | short_description | long_description | default_license | long_description_html | short_description_html ----+----------------+----------------+-------+---------+----------------------------+--------------------+-------------------+------------------+-----------------+-----------------------+------------------------ 3 | fediverse.blog | fediverse.blog | f | t | 2020-06-17 12:26:09.404793 | t | | | | | (1 row) ``` I am not sure how much of the log from processing posts/outboxes is in context or even interesting.... . I've installed Plume from Git on `tags/0.7.0`. It's https://write.tchncs.de if this helps in any way, now that we both discovered that it involves an instance under your control. ;)

KitaitiMakoto commented

2022-01-09 23:26:45 +00:00

Author

Owner

I found a bug that articles from remote instances are retrieved when a user visits remote user page like https://write.tchncs.de/@/KitaitiMakoto@fediverse.blog even if the instances are blocked. I will fix it.

Thank you so much for detailed information and sorry for inconvenience.

I found a bug that articles from remote instances are retrieved when a user visits remote user page like https://write.tchncs.de/@/KitaitiMakoto@fediverse.blog even if the instances are blocked. I will fix it. Thank you so much for detailed information and sorry for inconvenience.

KitaitiMakoto commented

2022-01-09 23:27:19 +00:00

Author

Owner

Custome timeline feature also may solve the problem.

KitaitiMakoto added this to the 0.8.0 milestone 2022-01-09 23:28:45 +00:00

KitaitiMakoto referenced this issue from a pull request that will close it,

2023-01-02 18:24:49 +00:00

Fix #966: Don't retrieve user info from blocked instances #1120

KitaitiMakoto referenced this issue from a commit

2023-01-04 16:11:35 +00:00

Merge pull request 'Fix #966: Don't retrieve user info from blocked instances' (#1120) from block-instance-user into main

KitaitiMakoto closed this issue

2023-01-04 16:11:39 +00:00

Rows
Columns

Blocking of instances does not work #966