Set limit for posts subtitle #987

New issue

Closed

opened 2022-01-04 10:49:55 +00:00 by mskf1383 · 5 comments

mskf1383 commented

2022-01-04 10:49:55 +00:00

Contributor

some users write all of the post's content in subtitle part and it's awfull!
Please set a limit for subtitle.
I think 154 is standard for SEO. Because it use as description in meta tags.
Thanks!

some users write all of the post's content in subtitle part and it's awfull! Please set a limit for subtitle. I think 154 is standard for SEO. Because it use as description in meta tags. Thanks!

KitaitiMakoto commented

2022-01-04 10:52:47 +00:00

Owner

You're right. We will implement.

Thank you!

You're right. We will implement. Thank you!

KitaitiMakoto added this to the 0.8.0 milestone 2022-01-04 10:52:55 +00:00

KitaitiMakoto commented

2022-01-04 10:55:09 +00:00

Owner

This might occur because it's hard to distinguish subtitle area and content area in rich text editor. If so, we should fix rich text editor.

Marius commented

2022-01-04 22:17:54 +00:00

A first way would be to add .truncate(154) on this function

fn get_subtitle() -> String {

So that it becomes:

fn get_subtitle() -> String {
    let subtitle = 
    	if is_basic_editor() {
        	get_elt_value("subtitle")
    	} else {
        	document()
            	.query_selector("#plume-editor > h2")
            	.unwrap()
            	.unwrap()
            	.dyn_ref::<HtmlElement>()
            	.unwrap()
            	.inner_text()
    	};
   subtitle.truncate(154);
   return subtitle;
}

Using https://doc.rust-lang.org/std/string/struct.String.html#method.truncate .

But then, this magic value of 154 has to be defined in some other file, in order to be easily modifiable.
I'm not familiar with Rust way of having a huge file with many useful constants, but maybe the lib.rs file could be a good one, where we put some:

const MAX_SUBTITLE_SIZE = 154;

Then we just have to import it and use it in place of 154.

A first way would be to add `.truncate(154)` on this function https://git.joinplu.me/Plume/Plume/src/commit/31b144c76de97fea4d07647285a87431d1d655cc/plume-front/src/editor.rs#L127 So that it becomes: ```rust fn get_subtitle() -> String { let subtitle = if is_basic_editor() { get_elt_value("subtitle") } else { document() .query_selector("#plume-editor > h2") .unwrap() .unwrap() .dyn_ref::<HtmlElement>() .unwrap() .inner_text() }; subtitle.truncate(154); return subtitle; } ``` Using https://doc.rust-lang.org/std/string/struct.String.html#method.truncate . But then, this *magic value* of 154 has to be defined in some other file, in order to be easily modifiable. I'm not familiar with Rust way of having a huge file with many useful constants, but maybe the **lib.rs** file could be a good one, where we put some: ```rust const MAX_SUBTITLE_SIZE = 154; ``` Then we just have to import it and use it in place of 154.

👀 1

KitaitiMakoto commented

2022-01-11 13:49:08 +00:00

Owner

Near 500 characters might be good because Mastodon shows subtitle and it shows at most 500 characters.