Panic less and with better messages #281

Sloučený

Plume_migration_agent sloučil 2 commity z větve panic-refactor do větve master před 2018-10-20 09:56:30 +00:00

trinity-1686a okomentoval/a

2018-10-20 09:14:34 +00:00

Vlastník

Fix #21
Change most unwrap to expect, and don't panic when it can be avoided. Also return better http codes, i.e. 400 and 404, when appropriate.
The trait rocker::request::FromParam should probably be implemented for Post, Blog, Media, User and Tag. Then we wouldn't need to return Options whenever an entity does not exist, and just let Rocket do the work for us

Fix #21 Change most unwrap to expect, and don't panic when it can be avoided. Also return better http codes, i.e. 400 and 404, when appropriate. The trait `rocker::request::FromParam` should probably be implemented for Post, Blog, Media, User and Tag. Then we wouldn't need to return `Option`s whenever an entity does not exist, and just let Rocket do the work for us

👍 1 ❤️ 1

elegaanz (Migrováno z github.com) schválil/a tyto změny 2018-10-20 09:55:17 +00:00

elegaanz (Migrováno z github.com) zanechal komentář

Thanks a lot!

elegaanz okomentoval/a

2018-10-20 09:56:24 +00:00

(Migrováno z github.com)

And yes, implementing FromParams for these types would be a good idea.

trinity-1686a okomentoval/a

2018-10-20 10:57:34 +00:00

Autor

Vlastník

After trying to, I guess it might not be possible, because we need a db connection, and I don't think there is a way to access managed state from from_param (it only takes a &RawStr as parameters). Nonetheless I'll ask on Matrix

elegaanz okomentoval/a

2018-10-20 11:24:58 +00:00

(Migrováno z github.com)

Maybe with with FromRequest and Request::get_param then? But it may force us to duplicate parameters in the routes signatures…

Maybe with with `FromRequest` and `Request::get_param` then? But it may force us to duplicate parameters in the routes signatures…

trinity-1686a okomentoval/a

2018-10-20 11:32:47 +00:00

Autor

Vlastník

If we end up doing manual routing it may reduce code duplication a bit, but it will add a lot of complexity, and we won't be able to use rocket's code generation if we do so. I'll see what answer I get from Matrix, but what I said earlier might very well be a false good idea

Přihlaste se pro zapojení do konverzace.

Žádní posuzovatelé

elegaanz

Žádný milník

Žádný projekt

Žádní přiřazení uživatelé

2 účastníků

Oznámení

Termín dokončení

Termín dokončení není platný nebo je mimo rozsah. Použijte prosím formát „rrrr-mm-dd“.

Žádný termín dokončení.

Závislosti

Nejsou nastaveny žádné závislosti.

Reference: Plume/Plume#281

K dispozici není žádný popis.

Řádky
Sloupce