Panic less and with better messages
#281
Fusionnée
Plume_migration_agent
a fusionné 2 révision(s) à partir de panic-refactor
vers master
il y a 6 ans
Chargement…
Référencer dans un nouveau ticket
Il n'existe pas encore de contenu.
Supprimer la branche 'panic-refactor'
Supprimer une branche est permanent. Cela NE PEUVENT être annulées. Continuer ?
Fix #21
Change most unwrap to expect, and don't panic when it can be avoided. Also return better http codes, i.e. 400 and 404, when appropriate.
The trait
rocker::request::FromParam
should probably be implemented for Post, Blog, Media, User and Tag. Then we wouldn't need to returnOption
s whenever an entity does not exist, and just let Rocket do the work for usThanks a lot!
And yes, implementing FromParams for these types would be a good idea.
After trying to, I guess it might not be possible, because we need a db connection, and I don't think there is a way to access managed state from from_param (it only takes a &RawStr as parameters). Nonetheless I'll ask on Matrix
Maybe with with
FromRequest
andRequest::get_param
then? But it may force us to duplicate parameters in the routes signatures…If we end up doing manual routing it may reduce code duplication a bit, but it will add a lot of complexity, and we won't be able to use rocket's code generation if we do so. I'll see what answer I get from Matrix, but what I said earlier might very well be a false good idea
Relecteurs
879fde81ba
.Étape 1:
Depuis le dépôt de votre projet, sélectionnez une nouvelle branche et testez les modifications.Étape 2:
Fusionner les modifications et mettre à jour sur Forgejo.