Panic less and with better messages #281

Merge aplicado

Plume_migration_agent mesclou 2 commits de panic-refactor em master

2018-10-20 09:56:30 +00:00

trinity-1686a comentou

2018-10-20 09:14:34 +00:00

Proprietário(a)

Fix #21
Change most unwrap to expect, and don't panic when it can be avoided. Also return better http codes, i.e. 400 and 404, when appropriate.
The trait rocker::request::FromParam should probably be implemented for Post, Blog, Media, User and Tag. Then we wouldn't need to return Options whenever an entity does not exist, and just let Rocket do the work for us

Fix #21 Change most unwrap to expect, and don't panic when it can be avoided. Also return better http codes, i.e. 400 and 404, when appropriate. The trait `rocker::request::FromParam` should probably be implemented for Post, Blog, Media, User and Tag. Then we wouldn't need to return `Option`s whenever an entity does not exist, and just let Rocket do the work for us

👍 1 ❤️ 1

elegaanz (Migrado de github.com) aprovou estas alterações 2018-10-20 09:55:17 +00:00

elegaanz (Migrado de github.com) deixou um comentário

Thanks a lot!

elegaanz comentou

2018-10-20 09:56:24 +00:00

(Migrado de github.com)

And yes, implementing FromParams for these types would be a good idea.

trinity-1686a comentou

2018-10-20 10:57:34 +00:00

Autor

Proprietário(a)

After trying to, I guess it might not be possible, because we need a db connection, and I don't think there is a way to access managed state from from_param (it only takes a &RawStr as parameters). Nonetheless I'll ask on Matrix

elegaanz comentou

2018-10-20 11:24:58 +00:00

(Migrado de github.com)

Maybe with with FromRequest and Request::get_param then? But it may force us to duplicate parameters in the routes signatures…

Maybe with with `FromRequest` and `Request::get_param` then? But it may force us to duplicate parameters in the routes signatures…

trinity-1686a comentou

2018-10-20 11:32:47 +00:00

Autor

Proprietário(a)

If we end up doing manual routing it may reduce code duplication a bit, but it will add a lot of complexity, and we won't be able to use rocket's code generation if we do so. I'll see what answer I get from Matrix, but what I said earlier might very well be a false good idea

Inicie a sessão para participar desta conversa.

Sem revisor

elegaanz

Sem marco

Sem projeto

Sem responsáveis

2 participantes

Notificações

Data limite

A data limite é inválida ou está fora do intervalo permitido. Por favor, use o formato "yyyy-mm-dd".

Não há data limite definida.

Dependências

Não há dependências definidas.

Referência: Plume/Plume#281

Nenhuma descrição fornecida.

Linhas
Colunas