Fix editor auto-expansion #293

Samengevoegd
elegaanz heeft 4 commits samengevoegd van issue-237 naar master 6 jaren geleden
elegaanz reageerde 6 jaren geleden (Gemigreerd van github.com)

Fixes #237

Another element with the content ID was present in the header.

Fixes #237 Another element with the `content` ID was present in the header.
Eigenaar

I've tried with a very big text (a few thousands words of lorem ipsum), the expansion works well, however I'm getting a weird effect when trying to edit anything behind the base size, it auto-scroll to the very beginning of the post at each key up, and go back to the cursor at each key down. The issue is reproducible on both Firefox (63) and Chromium (70)

I've tried with a very big text (a few thousands words of lorem ipsum), the expansion works well, however I'm getting a weird effect when trying to edit anything behind the base size, it auto-scroll to the very beginning of the post at each key up, and go back to the cursor at each key down. The issue is reproducible on both Firefox (63) and Chromium (70)
elegaanz reageerde 6 jaren geleden (Gemigreerd van github.com)

I can't reproduce (I tried with Firefox 63 and Chromium 70 too 🤷‍♀️)

I can't reproduce (I tried with Firefox 63 and Chromium 70 too :woman_shrugging:)
trinity-1686a beoordeeld 6 jaren geleden
@ -27,8 +27,8 @@
{% endfor %}
Eigenaar

the for should be modified to match textarea's new id

     <label for="plume-editor">{{ "Content" | _ }}<small>{{ "Markdown is supported" | _ }}</small></label>
the `for` should be modified to match textarea's new id ```suggestion <label for="plume-editor">{{ "Content" | _ }}<small>{{ "Markdown is supported" | _ }}</small></label> ```
Eigenaar

@BaptisteGelez that's odd, I tried again on a fresh Plume install and this is definitely reproducible on my side. I tried one single big paragraph, multiple small ones, one word per line... anything longer than 50 lines seems to trigger it (which is in fact more than the hard-coded 20 rows)

Also, not related but I think the id should be changed too in templates/posts/details.html.tera:112 (and its label), otherwise the comment editor won't be affected by those changes

@BaptisteGelez that's odd, I tried again on a fresh Plume install and this is definitely reproducible on my side. I tried one single big paragraph, multiple small ones, one word per line... anything longer than 50 lines seems to trigger it (which is in fact more than the hard-coded 20 rows) Also, not related but I think the id should be changed too in `templates/posts/details.html.tera:112` (and its label), otherwise the comment editor won't be affected by those changes
elegaanz reageerde 6 jaren geleden (Gemigreerd van github.com)

OK, I can indeed reproduce with a longer text. I'll try to fix it.

OK, I can indeed reproduce with a longer text. I'll try to fix it.
elegaanz reageerde 6 jaren geleden (Gemigreerd van github.com)

The issue has normally been fixed (all these commits could probably be squashed before merging BTW)

The issue has normally been fixed (all these commits could probably be squashed before merging BTW)
Eigenaar

So it no longer scroll back and forth, however it do scroll on the first keypress after moving the cursor. This is way better and can probably be merged as is, but we might want to take a look at it. What I get is not coherent between browser however : on Firefox the line being edited is aligned with the bottom of the screen, whereas in Chromium it's aligned with the middle of it

So it no longer scroll back and forth, however it do scroll on the first keypress after moving the cursor. This is way better and can probably be merged as is, but we might want to take a look at it. What I get is not coherent between browser however : on Firefox the line being edited is aligned with the bottom of the screen, whereas in Chromium it's aligned with the middle of it
elegaanz reageerde 6 jaren geleden (Gemigreerd van github.com)

I don't want to fight against browsers and their different implementation, so I will merge this branch as it is. If your issue is too problematic, we will still be able to fix it afterwards. This editor will (almost) disappear soon anyway…

I don't want to fight against browsers and their different implementation, so I will merge this branch as it is. If your issue is too problematic, we will still be able to fix it afterwards. This editor will (almost) disappear soon anyway…
De pull request is samengevoegd als 2e072affb5.
Je kunt ook command line instructies bekijken.

Stap 1:

Vanuit het project, check een branch uit en test de veranderingen.
git checkout -b issue-237 master
git pull origin issue-237

Stap 2:

Voeg de wijzigingen samen en update ze op Forgejo.
git checkout master
git merge --no-ff issue-237
git push origin master
Log in om deel te nemen aan deze discussie.
Geen beoordelaars
Geen mijlpaal
Niet toegewezen
2 deelnemers
Notificaties
Vervaldatum
De deadline is ongeldig of buiten bereik. Gebruik het formaat 'jjjj-mm-dd'.

Geen vervaldatum ingesteld.

Afhankelijkheden

Geen afhankelijkheden ingesteld.

Referentie: Plume/Plume#293
Laden…
Er is nog geen inhoud.