Fix editor auto-expansion
#293
Samengevoegd
elegaanz
heeft 4 commits samengevoegd van issue-237
naar master
6 jaren geleden
Reviewers
Beoordeling aanvragen
Geen beoordelaars
Labels
Verwijder labels
Related to the REST API
Code running on the server
Stuff related to Federation
Related to the front-end
Translations, and related code
More about project management or code than the project itself
The building, or installation process of Plume
Something isn't working
We need to talk
New feature or request
This is a new feature
Compatibility with different browsers, readers and OS
Related to an external package that Plume uses
UI/UX related issues and PRs
Good for newcomers
Extra attention is needed
Issues affecting only mobile UX
How elements're rendered out for the end user
Something else needs to be fixed first
This issue or pull request already exists
This PR is not complete yet
Issues concern a limited number of instances
This doesn't seem right
Need to be discussed by the community (on Loomio)
This PR is ready to be reviewed
Proposed ideas worth considering
This is issue has been created after a vote on Loomio
This will not be worked on
Labels toepassen
A: API
Related to the REST API
A: Backend
Code running on the server
A: Federation
Stuff related to Federation
A: Front-End
Related to the front-end
A: I18N
Translations, and related code
A: Meta
More about project management or code than the project itself
A: Security
Build
The building, or installation process of Plume
C: Bug
Something isn't working
C: Discussion
We need to talk
C: Enhancement
New feature or request
C: Feature
This is a new feature
Compatibility
Compatibility with different browsers, readers and OS
Dependency
Related to an external package that Plume uses
Design
UI/UX related issues and PRs
Documentation
Good first issue
Good for newcomers
Help welcome
Extra attention is needed
Mobile
Issues affecting only mobile UX
Rendering
How elements're rendered out for the end user
S: Blocked
Something else needs to be fixed first
S: Duplicate
This issue or pull request already exists
S: Incomplete
This PR is not complete yet
S: Instance specific
Issues concern a limited number of instances
S: Invalid
This doesn't seem right
S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio)
S: Ready for review
This PR is ready to be reviewed
Suggestion
Proposed ideas worth considering
S: Voted on Loomio
This is issue has been created after a vote on Loomio
S: Wontfix
This will not be worked on
Geen label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Mijlpaal
Stel mijlpaal in
Verwijder mijlpaal
Geen items
Geen mijlpaal
Toegewezen aan
Gebruikers toewijzen
Verwijder toegewezen aan
Niet toegewezen
2 deelnemers
Notificaties
Vervaldatum
De deadline is ongeldig of buiten bereik. Gebruik het formaat 'jjjj-mm-dd'.
Geen vervaldatum ingesteld.
Afhankelijkheden
Geen afhankelijkheden ingesteld.
Referentie: Plume/Plume#293
Verwijs in nieuw issue
Er is nog geen inhoud.
Verwijder branch 'issue-237'
Het verwijderen van een branch is permanent. Het KAN NIET ongedaan gemaakt worden. Wil je toch doorgaan?
Nee
Ja
Fixes #237
Another element with the
content
ID was present in the header.I've tried with a very big text (a few thousands words of lorem ipsum), the expansion works well, however I'm getting a weird effect when trying to edit anything behind the base size, it auto-scroll to the very beginning of the post at each key up, and go back to the cursor at each key down. The issue is reproducible on both Firefox (63) and Chromium (70)
I can't reproduce (I tried with Firefox 63 and Chromium 70 too 🤷♀️)
@ -27,8 +27,8 @@
{% endfor %}
the
for
should be modified to match textarea's new id@BaptisteGelez that's odd, I tried again on a fresh Plume install and this is definitely reproducible on my side. I tried one single big paragraph, multiple small ones, one word per line... anything longer than 50 lines seems to trigger it (which is in fact more than the hard-coded 20 rows)
Also, not related but I think the id should be changed too in
templates/posts/details.html.tera:112
(and its label), otherwise the comment editor won't be affected by those changesOK, I can indeed reproduce with a longer text. I'll try to fix it.
The issue has normally been fixed (all these commits could probably be squashed before merging BTW)
So it no longer scroll back and forth, however it do scroll on the first keypress after moving the cursor. This is way better and can probably be merged as is, but we might want to take a look at it. What I get is not coherent between browser however : on Firefox the line being edited is aligned with the bottom of the screen, whereas in Chromium it's aligned with the middle of it
I don't want to fight against browsers and their different implementation, so I will merge this branch as it is. If your issue is too problematic, we will still be able to fix it afterwards. This editor will (almost) disappear soon anyway…
2e072affb5
.Stap 1:
Vanuit het project, check een branch uit en test de veranderingen.Stap 2:
Voeg de wijzigingen samen en update ze op Forgejo.