Fix editor auto-expansion #293

trinity-1686a · 2018-10-25T16:48:54Z

elegaanz comentou

2018-10-25 16:48:54 +00:00

(Migrado de github.com)

Fixes #237

Another element with the content ID was present in the header.

Fixes #237 Another element with the `content` ID was present in the header.

trinity-1686a comentou

2018-10-27 20:53:45 +00:00

Proprietário(a)

I've tried with a very big text (a few thousands words of lorem ipsum), the expansion works well, however I'm getting a weird effect when trying to edit anything behind the base size, it auto-scroll to the very beginning of the post at each key up, and go back to the cursor at each key down. The issue is reproducible on both Firefox (63) and Chromium (70)

👍 1

elegaanz comentou

2018-10-29 20:13:39 +00:00

(Migrado de github.com)

I can't reproduce (I tried with Firefox 63 and Chromium 70 too 🤷‍♀️)

I can't reproduce (I tried with Firefox 63 and Chromium 70 too :woman_shrugging:)

trinity-1686a revisou 2018-10-29 23:11:43 +00:00

templates/posts/new.html.tera

					
				@ -27,8 +27,8 @@

				        {% endfor %}

trinity-1686a comentou

2018-10-29 23:11:42 +00:00

Proprietário(a)

the for should be modified to match textarea's new id

     <label for="plume-editor">{{ "Content" | _ }}<small>{{ "Markdown is supported" | _ }}</small></label>

the `for` should be modified to match textarea's new id ```suggestion <label for="plume-editor">{{ "Content" | _ }}<small>{{ "Markdown is supported" | _ }}</small></label> ```

trinity-1686a comentou

2018-10-29 23:20:17 +00:00

Proprietário(a)

@BaptisteGelez that's odd, I tried again on a fresh Plume install and this is definitely reproducible on my side. I tried one single big paragraph, multiple small ones, one word per line... anything longer than 50 lines seems to trigger it (which is in fact more than the hard-coded 20 rows)

Also, not related but I think the id should be changed too in templates/posts/details.html.tera:112 (and its label), otherwise the comment editor won't be affected by those changes

@BaptisteGelez that's odd, I tried again on a fresh Plume install and this is definitely reproducible on my side. I tried one single big paragraph, multiple small ones, one word per line... anything longer than 50 lines seems to trigger it (which is in fact more than the hard-coded 20 rows) Also, not related but I think the id should be changed too in `templates/posts/details.html.tera:112` (and its label), otherwise the comment editor won't be affected by those changes

elegaanz comentou

2018-10-30 10:55:40 +00:00

(Migrado de github.com)

OK, I can indeed reproduce with a longer text. I'll try to fix it.

elegaanz comentou

2018-10-30 11:33:15 +00:00

(Migrado de github.com)

The issue has normally been fixed (all these commits could probably be squashed before merging BTW)

trinity-1686a comentou

2018-10-30 15:55:40 +00:00

Proprietário(a)

So it no longer scroll back and forth, however it do scroll on the first keypress after moving the cursor. This is way better and can probably be merged as is, but we might want to take a look at it. What I get is not coherent between browser however : on Firefox the line being edited is aligned with the bottom of the screen, whereas in Chromium it's aligned with the middle of it

elegaanz comentou

2018-10-30 17:10:00 +00:00

(Migrado de github.com)

I don't want to fight against browsers and their different implementation, so I will merge this branch as it is. If your issue is too problematic, we will still be able to fix it afterwards. This editor will (almost) disappear soon anyway…

👍 1

Inicie a sessão para participar desta conversa.

Sem revisor

Sem marco

Sem projeto

Sem responsáveis

2 participantes

Notificações

Data limite

A data limite é inválida ou está fora do intervalo permitido. Por favor, use o formato "yyyy-mm-dd".

Não há data limite definida.

Dependências

Não há dependências definidas.

Referência: Plume/Plume#293

				`@ -27,8 +27,8 @@`
				`{% endfor %}`

Linhas
Colunas