Article cover
#299
Sammanfogat
elegaanz
sammanfogade 8 incheckningar från article-cover
in i master
5 år sedan
Granskare
Begär granskning
Inga granskare
Etiketter
Rensa etiketter
Related to the REST API
Code running on the server
Stuff related to Federation
Related to the front-end
Translations, and related code
More about project management or code than the project itself
The building, or installation process of Plume
Something isn't working
We need to talk
New feature or request
This is a new feature
Compatibility with different browsers, readers and OS
Related to an external package that Plume uses
UI/UX related issues and PRs
Good for newcomers
Extra attention is needed
Issues affecting only mobile UX
How elements're rendered out for the end user
Something else needs to be fixed first
This issue or pull request already exists
This PR is not complete yet
Issues concern a limited number of instances
This doesn't seem right
Need to be discussed by the community (on Loomio)
This PR is ready to be reviewed
Proposed ideas worth considering
This is issue has been created after a vote on Loomio
This will not be worked on
Tillämpa etiketter
A: API
Related to the REST API
A: Backend
Code running on the server
A: Federation
Stuff related to Federation
A: Front-End
Related to the front-end
A: I18N
Translations, and related code
A: Meta
More about project management or code than the project itself
A: Security
Build
The building, or installation process of Plume
C: Bug
Something isn't working
C: Discussion
We need to talk
C: Enhancement
New feature or request
C: Feature
This is a new feature
Compatibility
Compatibility with different browsers, readers and OS
Dependency
Related to an external package that Plume uses
Design
UI/UX related issues and PRs
Documentation
Good first issue
Good for newcomers
Help welcome
Extra attention is needed
Mobile
Issues affecting only mobile UX
Rendering
How elements're rendered out for the end user
S: Blocked
Something else needs to be fixed first
S: Duplicate
This issue or pull request already exists
S: Incomplete
This PR is not complete yet
S: Instance specific
Issues concern a limited number of instances
S: Invalid
This doesn't seem right
S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio)
S: Ready for review
This PR is ready to be reviewed
Suggestion
Proposed ideas worth considering
S: Voted on Loomio
This is issue has been created after a vote on Loomio
S: Wontfix
This will not be worked on
Ingen Etikett
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milsten
Ange milstolpe
Rensa milstenar
Inga objekt
Ingen Milsten
Tilldelade
Tilldela användare
Rensa tilldelade
Ingen tilldelad
2 Deltagare
Notiser
Förfallodatum
Förfallodatumet är ogiltigt eller utanför gränserna. Använd formatet 'åååå-mm-dd'.
Inget förfallodatum satt.
Beroenden
No dependencies set.
Reference: Plume/Plume#299
Referens i nytt ärende
Det finns inget innehåll än.
Ta bort branch 'article-cover'
Borttagning utav en branch är permanent. Detta KAN INTE ångras. Vill du fortsätta?
Nej
Ja
Screenshots:
Fixes #236
I'm not 100% satisfied with the cover selector (a
<select>
field listing your media) but if we want to have a JavaScript-free implementation and to avoid duplicating the media upload form, I don't see any better solution. 🤷♀️I'm getting an error when accessing the page to create a new post, however only when I have at least one media uploaded with that account, and there is no issue with
/~/<blog>/<slug>/edit
About the cover selector, to be frank I don't really like how medias works currently, it feels strange to go to /medias/ to change your avatar. It feels strange too to upload medias on a page different than the one where you write your posts (which will hopefully be better when we start working on a rich text editor), and choosing from a
<select>
what media will be the cover feels the same, maybe even worth for peoples having a lot of uploaded medias as the time goes. It can stay like that for the moment, but we will need to address this in the future.Also make me through of one thing : while it's using a
<select>
, you should filter to only show images, not audio content for example (actually the same goes for peoples avatar, currently they can be an audio file)@ -633,0 +633,4 @@
#, fuzzy
msgid "Illustration"
msgstr "Administration"
wow fuzzy translation is so wrong
Yes, I agree the way media are currently working is not ideal. I think we can change it once will we will switch to a new editor, by adding the possibility to upload an avatar directly from the profile edition page, and to add any other media directly from the editor.
Anyway changing how we handle medias is neither the goal nor in the scope of this pr, so even if it's less than ideal, it shouldn't affect how we merge this pr (and actually making sure people are not using a song as a picture is not that important as in the end how they select those will be totally changed latter on)
This is the exact line that is failing. I think you can't compare
form.cover
becauseform
isnull
when creating a new article.if not form.cover
(2 lines above) is legal as it verify the existence of the field, and its "nullness", but a compare only make sense if the field exist, it being null or notThose 3
println!
were for debug only I guess, so they should be removedOops, you're right. 😬
Granskare
25b7399e7f
.Step 1:
From your project repository, check out a new branch and test the changes.Step 2:
Merge the changes and update on Forgejo.