Post creation API #307

Yhdistetty

elegaanz yhdistetty 9 committia lähteestä post-api kohteeseen master

elegaanz kommentoi (Migrated from github.com)

Sisältöä ei vielä ole.

codecov[bot] kommentoi (Migrated from github.com)

Codecov Report

Merging #307 into master will decrease coverage by 0.44%.
The diff coverage is 11.34%.

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage    28.3%   27.86%   -0.45%     
==========================================
  Files          63       63              
  Lines        5949     6280     +331     
==========================================
+ Hits         1684     1750      +66     
- Misses       4265     4530     +265

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/307?src=pr&el=h1) Report > Merging [#307](https://codecov.io/gh/Plume-org/Plume/pull/307?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/fdfeeed6d9fa9dec92862366a8b646eb27d17422?src=pr&el=desc) will **decrease** coverage by `0.44%`. > The diff coverage is `11.34%`. ```diff @@ Coverage Diff @@ ## master #307 +/- ## ========================================== - Coverage 28.3% 27.86% -0.45% ========================================== Files 63 63 Lines 5949 6280 +331 ========================================== + Hits 1684 1750 +66 - Misses 4265 4530 +265 ```

elegaanz kommentoi (Migrated from github.com)

Ah, yes, I should write tests…

👍 2

elegaanz kommentoi (Migrated from github.com)

I think I will wait for #310 to be merged before adding tests, as it would probably create conflicts otherwise…

trinity-1686a reviewed

src/api/posts.rs

trinity-1686a kommentoi

Omistaja

anything after let conn = ... should be surrounded by a big

conn.test_transaction::<_, (), _>(|| { 
    [...]
    Ok(())
})

to prevent any side effect

anything after `let conn = ...` should be surrounded by a big ```rust conn.test_transaction::<_, (), _>(|| { [...] Ok(()) }) ``` to prevent any side effect

trinity-1686a kommentoi

Omistaja

Is this still ready for review? If so you should fix the conflict with master

trinity-1686a reviewed

trinity-1686a hyväksyi nämä muutokset

Reviewers

trinity-1686a hyväksyi nämä muutokset

The pull request has been merged as 4ec2480f50.

You can also view command line instructions.

Vaihe 1:

From your project repository, check out a new branch and test the changes.

git checkout -b post-api master

git pull origin post-api

Vaihe 2:

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff post-api

git push origin master

No reviewers

Ei merkkipaalua

Ei käsittelijää

2 osallistujaa

Ilmoitukset

Määräpäivä

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

Määräpäivää ei asetettu.

Riippuvuudet

Riippuvuuksia ei asetettu.

Ladataan…

Sisältöä ei vielä ole.

Tunnisteet Merkkipaalut

Post creation API #307

Codecov Report

Reviewers

Vaihe 1:

Vaihe 2: