Set Content-Type for ActivityPub request to correct value. #315

Merged

KokaKiwi merged 1 commit from ap-request-content-type into master 2018-11-23 12:18:33 +00:00

Conversation 1 Commits 1 Files changed 2 +5 -2

KokaKiwi commented 2018-11-23 01:10:31 +00:00 (Migrated from github.com)

Copy link

As defined in section 7 of the ActivityPub specification, POST requests must have the Content-Type: application/ld+json; profile="https://www.w3.org/ns/activitystreams" header

Also it allows implementations (like Pleroma) actually verifying content-types to correctly handle requests

As defined in [section 7 of the ActivityPub specification](https://www.w3.org/TR/activitypub/#server-to-server-interactions), `POST` requests must have the `Content-Type: application/ld+json; profile="https://www.w3.org/ns/activitystreams"` header Also it allows implementations (like Pleroma) actually verifying content-types to correctly handle requests

codecov[bot] commented 2018-11-23 01:29:20 +00:00 (Migrated from github.com)

Copy link

Codecov Report

Merging #315 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #315      +/-   ##
=========================================
- Coverage    5.13%   5.07%   -0.07%     
=========================================
  Files          55      55              
  Lines        3719    3763      +44     
=========================================
  Hits          191     191              
- Misses       3528    3572      +44

Impacted Files	Coverage Δ
plume-common/src/activity_pub/mod.rs	0% <0%> (ø)	⬆️
plume-common/src/activity_pub/request.rs	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00a205a...7c22a1f. Read the comment docs.

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/315?src=pr&el=h1) Report > Merging [#315](https://codecov.io/gh/Plume-org/Plume/pull/315?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/00a205a882aa0229fe33f358a7ba1b24171899d0?src=pr&el=desc) will **decrease** coverage by `0.06%`. > The diff coverage is `0%`. [](https://codecov.io/gh/Plume-org/Plume/pull/315?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #315 +/- ## ========================================= - Coverage 5.13% 5.07% -0.07% ========================================= Files 55 55 Lines 3719 3763 +44 ========================================= Hits 191 191 - Misses 3528 3572 +44 ``` | [Impacted Files](https://codecov.io/gh/Plume-org/Plume/pull/315?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [plume-common/src/activity\_pub/mod.rs](https://codecov.io/gh/Plume-org/Plume/pull/315/diff?src=pr&el=tree#diff-cGx1bWUtY29tbW9uL3NyYy9hY3Rpdml0eV9wdWIvbW9kLnJz) | `0% <0%> (ø)` | :arrow_up: | | [plume-common/src/activity\_pub/request.rs](https://codecov.io/gh/Plume-org/Plume/pull/315/diff?src=pr&el=tree#diff-cGx1bWUtY29tbW9uL3NyYy9hY3Rpdml0eV9wdWIvcmVxdWVzdC5ycw==) | `0% <0%> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/Plume-org/Plume/pull/315?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/315?src=pr&el=footer). Last update [00a205a...7c22a1f](https://codecov.io/gh/Plume-org/Plume/pull/315?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

trinity-1686a approved these changes 2018-11-23 08:23:47 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

trinity-1686a

Labels

Clear labels   

A: API

Related to the REST API

  

A: Backend

Code running on the server

  

A: Federation

Stuff related to Federation

  

A: Front-End

Related to the front-end

  

A: I18N

Translations, and related code

  

A: Meta

More about project management or code than the project itself

  

A: Security

  

Build

The building, or installation process of Plume

  

C: Bug

Something isn't working

  

C: Discussion

We need to talk

  

C: Enhancement

New feature or request

  

C: Feature

This is a new feature

  

Compatibility

Compatibility with different browsers, readers and OS

  

Dependency

Related to an external package that Plume uses

  

Design

UI/UX related issues and PRs

  

Documentation

  

Good first issue

Good for newcomers

  

Help welcome

Extra attention is needed

  

Mobile

Issues affecting only mobile UX

  

Rendering

How elements're rendered out for the end user

  

S: Blocked

Something else needs to be fixed first

  

S: Duplicate

This issue or pull request already exists

  

S: Incomplete

This PR is not complete yet

  

S: Instance specific

Issues concern a limited number of instances

  

S: Invalid

This doesn't seem right

  

S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  

S: Ready for review

This PR is ready to be reviewed

  

Suggestion

Proposed ideas worth considering

  

S: Voted on Loomio

This is issue has been created after a vote on Loomio

  

S: Wontfix

This will not be worked on

No labels

A: API

A: Backend

A: Federation

A: Front-End

A: I18N

A: Meta

A: Security

Build

C: Bug

C: Discussion

C: Enhancement

C: Feature

Compatibility

Dependency

Design

Documentation

Good first issue

Help welcome

Mobile

Rendering

S: Blocked

S: Duplicate

S: Incomplete

S: Instance specific

S: Invalid

S: Needs Voting/Discussion

S: Ready for review

Suggestion

S: Voted on Loomio

S: Wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#315

No description provided.