Make Plume compile on release #365

Merged
Plume_migration_agent merged 3 commits from compile-release into master 5 years ago
Owner

Remove use of String for body parameters
Create SignedJson and implement FromData for it

Fix #328

Remove use of String for body parameters Create SignedJson and implement FromData for it Fix #328
codecov[bot] commented 5 years ago (Migrated from github.com)

Codecov Report

Merging #365 into master will increase coverage by 0.53%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage    28.2%   28.73%   +0.53%     
==========================================
  Files          62       62              
  Lines        6578     5658     -920     
==========================================
- Hits         1855     1626     -229     
+ Misses       4723     4032     -691
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/365?src=pr&el=h1) Report > Merging [#365](https://codecov.io/gh/Plume-org/Plume/pull/365?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/ce083464872f012b89f997db783493cdea3f8ed7?src=pr&el=desc) will **increase** coverage by `0.53%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #365 +/- ## ========================================== + Coverage 28.2% 28.73% +0.53% ========================================== Files 62 62 Lines 6578 5658 -920 ========================================== - Hits 1855 1626 -229 + Misses 4723 4032 -691 ```
igalic (Migrated from github.com) reviewed 5 years ago
igalic (Migrated from github.com) left a comment

just 👀

just 👀
@ -44,1 +45,4 @@
self.value()==other.value()
}
pub fn algorithm(&self) -> &str {
igalic (Migrated from github.com) commented 5 years ago

i just realised we have a lot of public functions here, but don't document any

i just realised we have a lot of public functions here, but don't document any
trinity-1686a reviewed 5 years ago
@ -44,1 +45,4 @@
self.value()==other.value()
}
pub fn algorithm(&self) -> &str {
Poster
Owner

Yes, we should do it. Also we should probably use https://git.asonix.dog/asonix/http-signatures instead of rolling our own code

Yes, we should do it. Also we should probably use https://git.asonix.dog/asonix/http-signatures instead of rolling our own code
igalic commented 5 years ago (Migrated from github.com)

we should also expand our .travis.yml to (test) build release

we should also expand our .travis.yml to (test) build `release`
Poster
Owner

Maybe we should just test in release, that's what peoples will use anyway

Maybe we should just test in release, that's what peoples will use anyway
igalic commented 5 years ago (Migrated from github.com)

except for us developers, so, yeah, 👍

except for us developers, so, yeah, 👍
Poster
Owner

I should also update install instructions
Edit: actually documentation already use release, no wonder people where asking for help with installation

I should also update install instructions Edit: actually documentation already use release, no wonder people where asking for help with installation
Poster
Owner

Oops I broke code coverage even more I think
Can't complain about low coverage if you don't upload any coverage report 🙃

Oops I broke code coverage even more I think Can't complain about low coverage if you don't upload any coverage report :upside_down_face:
marek-lach commented 5 years ago (Migrated from github.com)

Just posting this here, as it might be relevant for this pull request:

https://mstdn.nipponalba.scot/@jk/101279615979810008

Just posting this here, as it might be relevant for this pull request: https://mstdn.nipponalba.scot/@jk/101279615979810008
elegaanz commented 5 years ago (Migrated from github.com)

@marek-lach Thanks! It is indeed related. I responded them.

@marek-lach Thanks! It is indeed related. I responded them.
elegaanz (Migrated from github.com) approved these changes 5 years ago
elegaanz (Migrated from github.com) left a comment

Thanks!

Thanks!

Reviewers

The pull request has been merged as ab2998e214.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b compile-release master
git pull origin compile-release

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff compile-release
git push origin master
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#365
Loading…
There is no content yet.