An attempt to fix disorted submit button on mobile devices like iPhone - please review #370

Обединени

marek-lach обедини 3 ревизии от patch-1 във master

marek-lach коментира (Migrated from github.com)

Все още няма съдържание.

elegaanz коментира (Migrated from github.com)

@marek-lach Hello! What was the issue you are trying to fix? I can't find anything similar to what you describe in the title…

codecov[bot] коментира (Migrated from github.com)

Codecov Report

Merging #370 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   28.47%   28.47%           
=======================================
  Files          62       62           
  Lines        5706     5706           
=======================================
  Hits         1625     1625           
  Misses       4081     4081

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/370?src=pr&el=h1) Report > Merging [#370](https://codecov.io/gh/Plume-org/Plume/pull/370?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/5c5cf36b0d6609127793e22ed315edf5a5c689d2?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #370 +/- ## ======================================= Coverage 28.47% 28.47% ======================================= Files 62 62 Lines 5706 5706 ======================================= Hits 1625 1625 Misses 4081 4081 ```

marek-lach коментира (Migrated from github.com)

Problem:
When on a mobile device, like an iPhone, the submit comment button gets disorted (i.e. out of shape, squashed) when you press submit. As far as I know, this isn't the case on the desktop.

Before pressing the submit button for a comment on an iPhone (though I suspect Android's the same):

After pressing the submit button on an iPhone (it works, the distortion is just a visual CSS problem):

I am sure the fix for this has to do with responsivness of the submit button, and it must be easy to do, but addmitedly I have no idea, what precisely would fix it, just took a guess.

**Problem:** When on a mobile device, like an iPhone, the submit comment button gets disorted (i.e. out of shape, squashed) when you press submit. As far as I know, this isn't the case on the desktop. Before pressing the submit button for a comment on an iPhone (though I suspect Android's the same): ![img_0551](https://user-images.githubusercontent.com/45913977/50384758-19a1ce00-06c1-11e9-89f4-7e85ca6bcd03.PNG) After pressing the submit button on an iPhone (it works, the distortion is just a visual CSS problem): ![img_0552](https://user-images.githubusercontent.com/45913977/50384770-51107a80-06c1-11e9-92df-8088fd998695.PNG) I am sure the fix for this has to do with responsivness of the submit button, and it must be easy to do, but addmitedly I have no idea, what precisely would fix it, just took a guess.

elegaanz коментира (Migrated from github.com)

This seems to be related to Safari's rendering engine (I cant' reproduce on my Android phone), and I have no iPhone to test. If it doesn't break anything I'll merge your change, hoping it will fix the issue…

elegaanz (Migrated from github.com) requested changes

elegaanz (Migrated from github.com) left a comment

It doesn't work: no border is displayed at all… 😕

It doesn't work: no border is displayed at all… :confused:

marek-lach коментира (Migrated from github.com)

Right, couldn't reproduce the problem on Android. Will try to modify specifically for Safari only then.

marek-lach коментира (Migrated from github.com)

Hmm... reverted the change and tried a Safari-specific style. Let me know if the border is back as before with this last commit.

elegaanz (Migrated from github.com) requested changes

elegaanz (Migrated from github.com) left a comment

I don't have the issue with borders anymore, but I have some other issues, for instance on the user page:

I think this is the same issue as here: https://stackoverflow.com/a/5438653

I don't have the issue with borders anymore, but I have some other issues, for instance on the user page: ![2018-12-23-163432_362x492_scrot](https://user-images.githubusercontent.com/16254623/50385167-dc453c80-06d0-11e9-9f9c-338a29ba4c4f.png) I think this is the same issue as here: https://stackoverflow.com/a/5438653

marek-lach коментира (Migrated from github.com)

I have reverted all of the changes up to now, and added the suggested webkit-specific fix as advised on stack owerflow. As long as this does not disort anything anywhere else, it might work as a quick solution to the problem for now...

elegaanz (Migrated from github.com) approved these changes

elegaanz (Migrated from github.com) left a comment

Thanks! Looks good now. I hope it will fix your issue.

Reviewers

Тази заявка за сливане е била обединена като 2621549f5e.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b patch-1 master

git pull origin patch-1

Step 2:

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff patch-1

git push origin master

Впишете се за да се присъедините към разговора.

No reviewers

Няма етап

Няма изпълнители

1 участника

Известия

Due Date

Крайният срок е невалиден или извън обхват. Моля използвайте форматът 'гггг-мм-дд'.

No due date set.

Зависимости

No dependencies set.

Зареждане…

Все още няма съдържание.

Етикети Етапи

An attempt to fix disorted submit button on mobile devices like iPhone - please review #370

Codecov Report

Reviewers

Step 1:

Step 2: