8
16
Fork 22

An attempt to fix disorted submit button on mobile devices like iPhone - please review #370

Zusammengeführt
marek-lach hat 3 Commits von patch-1 nach master vor 5 Jahren zusammengeführt
marek-lach hat vor 5 Jahren kommentiert (Migriert von github.com)
Hier gibt es bis jetzt noch keinen Inhalt.
elegaanz hat vor 5 Jahren kommentiert (Migriert von github.com)

@marek-lach Hello! What was the issue you are trying to fix? I can't find anything similar to what you describe in the title…

@marek-lach Hello! What was the issue you are trying to fix? I can't find anything similar to what you describe in the title…
codecov[bot] hat vor 5 Jahren kommentiert (Migriert von github.com)

Codecov Report

Merging #370 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   28.47%   28.47%           
=======================================
  Files          62       62           
  Lines        5706     5706           
=======================================
  Hits         1625     1625           
  Misses       4081     4081
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/370?src=pr&el=h1) Report > Merging [#370](https://codecov.io/gh/Plume-org/Plume/pull/370?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/5c5cf36b0d6609127793e22ed315edf5a5c689d2?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #370 +/- ## ======================================= Coverage 28.47% 28.47% ======================================= Files 62 62 Lines 5706 5706 ======================================= Hits 1625 1625 Misses 4081 4081 ```
marek-lach hat vor 5 Jahren kommentiert (Migriert von github.com)

Problem:
When on a mobile device, like an iPhone, the submit comment button gets disorted (i.e. out of shape, squashed) when you press submit. As far as I know, this isn't the case on the desktop.

Before pressing the submit button for a comment on an iPhone (though I suspect Android's the same):

img_0551

After pressing the submit button on an iPhone (it works, the distortion is just a visual CSS problem):
img_0552

I am sure the fix for this has to do with responsivness of the submit button, and it must be easy to do, but addmitedly I have no idea, what precisely would fix it, just took a guess.

**Problem:** When on a mobile device, like an iPhone, the submit comment button gets disorted (i.e. out of shape, squashed) when you press submit. As far as I know, this isn't the case on the desktop. Before pressing the submit button for a comment on an iPhone (though I suspect Android's the same): ![img_0551](https://user-images.githubusercontent.com/45913977/50384758-19a1ce00-06c1-11e9-89f4-7e85ca6bcd03.PNG) After pressing the submit button on an iPhone (it works, the distortion is just a visual CSS problem): ![img_0552](https://user-images.githubusercontent.com/45913977/50384770-51107a80-06c1-11e9-92df-8088fd998695.PNG) I am sure the fix for this has to do with responsivness of the submit button, and it must be easy to do, but addmitedly I have no idea, what precisely would fix it, just took a guess.
elegaanz hat vor 5 Jahren kommentiert (Migriert von github.com)

This seems to be related to Safari's rendering engine (I cant' reproduce on my Android phone), and I have no iPhone to test. If it doesn't break anything I'll merge your change, hoping it will fix the issue…

This seems to be related to Safari's rendering engine (I cant' reproduce on my Android phone), and I have no iPhone to test. If it doesn't break anything I'll merge your change, hoping it will fix the issue…
elegaanz (Migriert von github.com) hat vor 5 Jahren Änderungen angefragt
elegaanz (Migriert von github.com) hat einen Kommentar hinterlassen

It doesn't work: no border is displayed at all… 😕

It doesn't work: no border is displayed at all… :confused:
marek-lach hat vor 5 Jahren kommentiert (Migriert von github.com)

Right, couldn't reproduce the problem on Android. Will try to modify specifically for Safari only then.

Right, couldn't reproduce the problem on Android. Will try to modify specifically for Safari only then.
marek-lach hat vor 5 Jahren kommentiert (Migriert von github.com)

Hmm... reverted the change and tried a Safari-specific style. Let me know if the border is back as before with this last commit.

Hmm... reverted the change and tried a Safari-specific style. Let me know if the border is back as before with this last commit.
elegaanz (Migriert von github.com) hat vor 5 Jahren Änderungen angefragt
elegaanz (Migriert von github.com) hat einen Kommentar hinterlassen

I don't have the issue with borders anymore, but I have some other issues, for instance on the user page:

2018-12-23-163432_362x492_scrot

I think this is the same issue as here: https://stackoverflow.com/a/5438653

I don't have the issue with borders anymore, but I have some other issues, for instance on the user page: ![2018-12-23-163432_362x492_scrot](https://user-images.githubusercontent.com/16254623/50385167-dc453c80-06d0-11e9-9f9c-338a29ba4c4f.png) I think this is the same issue as here: https://stackoverflow.com/a/5438653
marek-lach hat vor 5 Jahren kommentiert (Migriert von github.com)

I have reverted all of the changes up to now, and added the suggested webkit-specific fix as advised on stack owerflow. As long as this does not disort anything anywhere else, it might work as a quick solution to the problem for now...

I have reverted all of the changes up to now, and added the suggested webkit-specific fix as advised on stack owerflow. As long as this does not disort anything anywhere else, it might work as a quick solution to the problem for now...
elegaanz (Migriert von github.com) hat die Änderungen vor 5 Jahren genehmigt
elegaanz (Migriert von github.com) hat einen Kommentar hinterlassen

Thanks! Looks good now. I hope it will fix your issue.

Thanks! Looks good now. I hope it will fix your issue.

Reviewer

Der Pull Request wurde als 2621549f5e gemergt.

Schritt 1:

Wechsle auf einen neuen Branch in deinem lokalen Repository und teste die Änderungen.
git checkout -b patch-1 master
git pull origin patch-1

Schritt 2:

Führe die Änderungen zusammen und aktualisiere den Stand online auf Forgejo.
git checkout master
git merge --no-ff patch-1
git push origin master
Anmelden, um an der Diskussion teilzunehmen.
Keine Reviewer
Kein Meilenstein
Niemand zuständig
1 Beteiligte
Nachrichten
Fällig am
Das Fälligkeitsdatum ist ungültig oder außerhalb des zulässigen Bereichs. Bitte verwende das Format „jjjj-mm-tt“.

Kein Fälligkeitsdatum gesetzt.

Abhängigkeiten

Keine Abhängigkeiten gesetzt.

Referenz: Plume/Plume#370
Laden…
Hier gibt es bis jetzt noch keinen Inhalt.