An attempt to fix disorted submit button on mobile devices like iPhone - please review
#370
Scalone
marek-lach
scala 3 commity/ów z patch-1
do master
5 lat temu
Recenzenci
Poproś o recenzję
Brak recenzentów
Etykiety
Wyczyść etykiety
Related to the REST API
Code running on the server
Stuff related to Federation
Related to the front-end
Translations, and related code
More about project management or code than the project itself
The building, or installation process of Plume
Something isn't working
We need to talk
New feature or request
This is a new feature
Compatibility with different browsers, readers and OS
Related to an external package that Plume uses
UI/UX related issues and PRs
Good for newcomers
Extra attention is needed
Issues affecting only mobile UX
How elements're rendered out for the end user
Something else needs to be fixed first
This issue or pull request already exists
This PR is not complete yet
Issues concern a limited number of instances
This doesn't seem right
Need to be discussed by the community (on Loomio)
This PR is ready to be reviewed
Proposed ideas worth considering
This is issue has been created after a vote on Loomio
This will not be worked on
Zastosuj etykiety
A: API
Related to the REST API
A: Backend
Code running on the server
A: Federation
Stuff related to Federation
A: Front-End
Related to the front-end
A: I18N
Translations, and related code
A: Meta
More about project management or code than the project itself
A: Security
Build
The building, or installation process of Plume
C: Bug
Something isn't working
C: Discussion
We need to talk
C: Enhancement
New feature or request
C: Feature
This is a new feature
Compatibility
Compatibility with different browsers, readers and OS
Dependency
Related to an external package that Plume uses
Design
UI/UX related issues and PRs
Documentation
Good first issue
Good for newcomers
Help welcome
Extra attention is needed
Mobile
Issues affecting only mobile UX
Rendering
How elements're rendered out for the end user
S: Blocked
Something else needs to be fixed first
S: Duplicate
This issue or pull request already exists
S: Incomplete
This PR is not complete yet
S: Instance specific
Issues concern a limited number of instances
S: Invalid
This doesn't seem right
S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio)
S: Ready for review
This PR is ready to be reviewed
Suggestion
Proposed ideas worth considering
S: Voted on Loomio
This is issue has been created after a vote on Loomio
S: Wontfix
This will not be worked on
Brak etykiety
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Kamień milowy
Ustaw kamień milowy
Wyczyść kamień milowy
Brak elementów
Brak kamienia milowego
Przypisani
Przypisz użytkowników
Usuń przypisanych
Brak przypisanych
Uczestnicy 1
Powiadomienia
Termin realizacji
Data realizacji jest niewłaściwa lub spoza zakresu. Użyj formatu 'yyyy-mm-dd'.
Brak ustawionego terminu realizacji.
Zależności
No dependencies set.
Reference: Plume/Plume#370
Reference in New Issue
Nie ma jeszcze treści.
Usuń gałąź 'patch-1'
Usunięcie gałęzi jest trwałe i NIE MOŻE zostać cofnięte. Kontynuować?
Nie
Tak
@marek-lach Hello! What was the issue you are trying to fix? I can't find anything similar to what you describe in the title…
Codecov Report
Problem:
When on a mobile device, like an iPhone, the submit comment button gets disorted (i.e. out of shape, squashed) when you press submit. As far as I know, this isn't the case on the desktop.
Before pressing the submit button for a comment on an iPhone (though I suspect Android's the same):
After pressing the submit button on an iPhone (it works, the distortion is just a visual CSS problem):
I am sure the fix for this has to do with responsivness of the submit button, and it must be easy to do, but addmitedly I have no idea, what precisely would fix it, just took a guess.
This seems to be related to Safari's rendering engine (I cant' reproduce on my Android phone), and I have no iPhone to test. If it doesn't break anything I'll merge your change, hoping it will fix the issue…
It doesn't work: no border is displayed at all… 😕
Right, couldn't reproduce the problem on Android. Will try to modify specifically for Safari only then.
Hmm... reverted the change and tried a Safari-specific style. Let me know if the border is back as before with this last commit.
I don't have the issue with borders anymore, but I have some other issues, for instance on the user page:
I think this is the same issue as here: https://stackoverflow.com/a/5438653
I have reverted all of the changes up to now, and added the suggested webkit-specific fix as advised on stack owerflow. As long as this does not disort anything anywhere else, it might work as a quick solution to the problem for now...
Thanks! Looks good now. I hope it will fix your issue.
Recenzenci
2621549f5e
.Krok 1:
Z repozytorium twojego projektu, sprawdź nową gałąź i przetestuj zmiany.Krok 2:
Połącz zmiany i zaktualizuj na Forgejo.