Use Rust for the front-end too #374

Fusionnée

elegaanz a fusionné 11 révision(s) à partir de wasm vers master

elegaanz a commenté (Migré de github.com)

Rust can compile to WASM, so let's use it for front-end code as well.

To compile the front-end:

cargo install cargo-web
cd plume-front
cargo web deploy -o ../static

Rust can compile to WASM, so let's use it for front-end code as well. To compile the front-end: ``` cargo install cargo-web cd plume-front cargo web deploy -o ../static ```

trinity-1686a révisé

trinity-1686a laisser un commentaire

Propriétaire

I've had a hard time testing this. I think it would be better to cargo web deploy without location, and do some processing (adding static/ to path so the new route is not required) and copying by ourselves in build.rs. Currently the instructions are polluting static/ with an index.html

I've had a hard time testing this. I think it would be better to `cargo web deploy` without location, and do some processing (adding `static/` to path so the new route is not required) and copying by ourselves in build.rs. Currently the instructions are polluting `static/` with an `index.html`

static/plume-front.js

trinity-1686a a commenté

Propriétaire

I think this file souldn't be committed, it's auto generated and things like __cargo_web_snippet_199d5eb25dfe761687bcd487578eb7e636bd9650 are probably not reproducible between builds

I think this file souldn't be committed, it's auto generated and things like `__cargo_web_snippet_199d5eb25dfe761687bcd487578eb7e636bd9650` are probably not reproducible between builds

elegaanz a commenté (Migré de github.com)

You can now just use cargo web deploy, build.rs will do the rest.

You can now just use `cargo web deploy`, build.rs will do the rest.

👍 1

igalic a commenté (Migré de github.com)

how much faster is the resulting wasm compared to the previous Javascript?

trinity-1686a a commenté

Propriétaire

@igalic considering our use-case, probably not much. The main advantage is the whole team being able to debug it I think

👍 2

elegaanz a commenté (Migré de github.com)

There may be better performances once with the future editor, especially when writing big articles. Another advantage is that we will be able to share code between backend and frontend if we need it.

👍 1

trinity-1686a a commenté

Propriétaire

@BaptisteGelez I see Travis failed because of cargo-web installation, you might be interested into this https://github.com/koute/cargo-web#using-cargo-web-on-travis .

👍 1

codecov[bot] a commenté (Migré de github.com)

Codecov Report

Merging #374 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #374   +/-   ##
=======================================
  Coverage   27.86%   27.86%           
=======================================
  Files          63       63           
  Lines        6280     6280           
=======================================
  Hits         1750     1750           
  Misses       4530     4530

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/374?src=pr&el=h1) Report > Merging [#374](https://codecov.io/gh/Plume-org/Plume/pull/374?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/22bc8c1d407cd4c3844aaa1161afd2a86f6d349a?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #374 +/- ## ======================================= Coverage 27.86% 27.86% ======================================= Files 63 63 Lines 6280 6280 ======================================= Hits 1750 1750 Misses 4530 4530 ```

trinity-1686a révisé

trinity-1686a laisser un commentaire

Propriétaire

You should also update documentation, something like add "run cargo web deploy -p plume-front"

You should also update documentation, something like add "run `cargo web deploy -p plume-front`"

.gitignore

trinity-1686a a commenté

Propriétaire

this line is no longer required

trinity-1686a ces changements ont été approuvés

Relecteurs

trinity-1686a ces changements ont été approuvés

La demande d'ajout a été fusionnée en 3fce5d6a14.

Vous pouvez également voir les instructions en ligne de commande.

Étape 1:

Depuis le dépôt de votre projet, sélectionnez une nouvelle branche et testez les modifications.

git checkout -b wasm master

git pull origin wasm

Étape 2:

Fusionner les modifications et mettre à jour sur Forgejo.

git checkout master

git merge --no-ff wasm

git push origin master

Connectez-vous pour rejoindre cette conversation.

Aucune évaluation

Aucun jalon

Pas d'assignataires

2 participants

Notifications

Échéance

La date d’échéance est invalide ou hors plage. Veuillez utiliser le format 'aaaa-mm-dd'.

Aucune échéance n'a été définie.

Dépendances

No dependencies set.

Chargement…

Il n'existe pas encore de contenu.

Étiquettes Jalons

Use Rust for the front-end too #374

Codecov Report

Relecteurs

Étape 1:

Étape 2: