Plume/Plume

Vork 24

Use Rust for the front-end too #374

Samengevoegd

elegaanz heeft 11 commits samengevoegd van wasm naar master

2018-12-25 10:51:41 +00:00

elegaanz reageerde

2018-12-23 21:31:34 +00:00

(Gemigreerd van github.com)

Rust can compile to WASM, so let's use it for front-end code as well.

To compile the front-end:

cargo install cargo-web
cd plume-front
cargo web deploy -o ../static

Rust can compile to WASM, so let's use it for front-end code as well. To compile the front-end: ``` cargo install cargo-web cd plume-front cargo web deploy -o ../static ```

trinity-1686a beoordeeld 2018-12-24 00:39:08 +00:00

trinity-1686a heeft een reactie achtergelaten

Eigenaar

I've had a hard time testing this. I think it would be better to cargo web deploy without location, and do some processing (adding static/ to path so the new route is not required) and copying by ourselves in build.rs. Currently the instructions are polluting static/ with an index.html

I've had a hard time testing this. I think it would be better to `cargo web deploy` without location, and do some processing (adding `static/` to path so the new route is not required) and copying by ourselves in build.rs. Currently the instructions are polluting `static/` with an `index.html`

static/plume-front.js

trinity-1686a reageerde

2018-12-24 00:33:39 +00:00

Eigenaar

I think this file souldn't be committed, it's auto generated and things like __cargo_web_snippet_199d5eb25dfe761687bcd487578eb7e636bd9650 are probably not reproducible between builds

I think this file souldn't be committed, it's auto generated and things like `__cargo_web_snippet_199d5eb25dfe761687bcd487578eb7e636bd9650` are probably not reproducible between builds

elegaanz reageerde

2018-12-24 09:26:07 +00:00

(Gemigreerd van github.com)

You can now just use cargo web deploy, build.rs will do the rest.

You can now just use `cargo web deploy`, build.rs will do the rest.

👍 1

igalic reageerde

2018-12-24 10:26:25 +00:00

(Gemigreerd van github.com)

how much faster is the resulting wasm compared to the previous Javascript?

trinity-1686a reageerde

2018-12-24 10:32:48 +00:00

Eigenaar

@igalic considering our use-case, probably not much. The main advantage is the whole team being able to debug it I think

👍 2

elegaanz reageerde

2018-12-24 10:34:11 +00:00

(Gemigreerd van github.com)

There may be better performances once with the future editor, especially when writing big articles. Another advantage is that we will be able to share code between backend and frontend if we need it.

👍 1

trinity-1686a reageerde

2018-12-24 11:41:39 +00:00

Eigenaar

@BaptisteGelez I see Travis failed because of cargo-web installation, you might be interested into this https://github.com/koute/cargo-web#using-cargo-web-on-travis .

👍 1

codecov[bot] reageerde

2018-12-24 14:45:05 +00:00

(Gemigreerd van github.com)

Codecov Report

Merging #374 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #374   +/-   ##
=======================================
  Coverage   27.86%   27.86%           
=======================================
  Files          63       63           
  Lines        6280     6280           
=======================================
  Hits         1750     1750           
  Misses       4530     4530

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/374?src=pr&el=h1) Report > Merging [#374](https://codecov.io/gh/Plume-org/Plume/pull/374?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/22bc8c1d407cd4c3844aaa1161afd2a86f6d349a?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #374 +/- ## ======================================= Coverage 27.86% 27.86% ======================================= Files 63 63 Lines 6280 6280 ======================================= Hits 1750 1750 Misses 4530 4530 ```

trinity-1686a beoordeeld 2018-12-24 19:09:28 +00:00

trinity-1686a heeft een reactie achtergelaten

Eigenaar

You should also update documentation, something like add "run cargo web deploy -p plume-front"

You should also update documentation, something like add "run `cargo web deploy -p plume-front`"

.gitignore

trinity-1686a reageerde

2018-12-24 19:00:16 +00:00

Eigenaar

this line is no longer required

trinity-1686a heeft deze veranderingen 2018-12-25 10:50:39 +00:00 goedgekeurd

Geen beoordelaars

Geen mijlpaal

Geen project

Niet toegewezen

2 deelnemers

Notificaties

Vervaldatum

De deadline is ongeldig of buiten bereik. Gebruik het formaat "jjjj-mm-dd'.

Geen vervaldatum ingesteld.

Afhankelijkheden

Geen afhankelijkheden ingesteld.

Referentie: Plume/Plume#374

Geen beschrijving gegeven.

Rijen
Kolommen