Improve search UI #375

Fusionnée
elegaanz a fusionné 2 révision(s) à partir de search-ui vers master il y a 5 ans
elegaanz a commenté il y a 5 ans (Migré de github.com)
  • Add a link to the search page in the header
  • Translate it

I also removed placeholders because there were not adding much value, and were making the code harder to read when translated (I don't know if it was really a good idea, maybe we should keep them ?).

- Add a link to the search page in the header - Translate it I also removed placeholders because there were not adding much value, and were making the code harder to read when translated (I don't know if it was really a good idea, maybe we should keep them ?).
Propriétaire

Whoops all this got totally off my mind. I don't like where is placed the search button when connected, but I see no better place to put it. Concerning placeholders, I think it feel a bit empty without them 😐

Whoops all this got totally off my mind. I don't like where is placed the search button when connected, but I see no better place to put it. Concerning placeholders, I think it feel a bit empty without them :neutral_face:
codecov[bot] a commenté il y a 5 ans (Migré de github.com)

Codecov Report

Merging #375 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage    28.3%   28.27%   -0.03%     
==========================================
  Files          63       63              
  Lines        5949     5955       +6     
==========================================
  Hits         1684     1684              
- Misses       4265     4271       +6
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/375?src=pr&el=h1) Report > Merging [#375](https://codecov.io/gh/Plume-org/Plume/pull/375?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/fdfeeed6d9fa9dec92862366a8b646eb27d17422?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #375 +/- ## ========================================== - Coverage 28.3% 28.27% -0.03% ========================================== Files 63 63 Lines 5949 5955 +6 ========================================== Hits 1684 1684 - Misses 4265 4271 +6 ```
codecov[bot] a commenté il y a 5 ans (Migré de github.com)

Codecov Report

Merging #375 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   27.64%   27.62%   -0.03%     
==========================================
  Files          63       63              
  Lines        7336     7342       +6     
==========================================
  Hits         2028     2028              
- Misses       5308     5314       +6
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/375?src=pr&el=h1) Report > Merging [#375](https://codecov.io/gh/Plume-org/Plume/pull/375?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a2ddfb0ee91c575bb0d9c1d42944a78e75f9669f?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #375 +/- ## ========================================== - Coverage 27.64% 27.62% -0.03% ========================================== Files 63 63 Lines 7336 7342 +6 ========================================== Hits 2028 2028 - Misses 5308 5314 +6 ```
elegaanz a commenté il y a 5 ans (Migré de github.com)

Ok, I'll had placeholders back. And for the button, maybe putting it before the Dashboard button?

Ok, I'll had placeholders back. And for the button, maybe putting it before the Dashboard button?
Propriétaire

I tried, it's maybe a bit better. I think my issue is there start to be maybe too many buttons here, maybe replacing the /me link with a drop-down where you can also logout and see your dashboard? But that would need it's own pr I think

I tried, it's maybe a bit better. I think my issue is there start to be maybe too many buttons here, maybe replacing the /me link with a drop-down where you can also logout and see your dashboard? But that would need it's own pr I think
trinity-1686a ces changements ont été approuvés il y a 5 ans
trinity-1686a laisser un commentaire
Propriétaire

sorry to react so late, I did not notice you added placeholders back while merging before

sorry to react so late, I did not notice you added placeholders back while merging before
elegaanz a commenté il y a 5 ans (Migré de github.com)

No problem. 🙂

No problem. :slightly_smiling_face:

Relecteurs

trinity-1686a ces changements ont été approuvés il y a 5 ans
La demande d'ajout a été fusionnée en 5880dc1957.
Vous pouvez également voir les instructions en ligne de commande.

Étape 1:

Depuis le dépôt de votre projet, sélectionnez une nouvelle branche et testez les modifications.
git checkout -b search-ui master
git pull origin search-ui

Étape 2:

Fusionner les modifications et mettre à jour sur Forgejo.
git checkout master
git merge --no-ff search-ui
git push origin master
Connectez-vous pour rejoindre cette conversation.
Aucune évaluation
Aucun jalon
Pas d'assignataires
2 participants
Notifications
Échéance
La date d’échéance est invalide ou hors plage. Veuillez utiliser le format 'aaaa-mm-dd'.

Aucune échéance n'a été définie.

Dépendances

No dependencies set.

Reference: Plume/Plume#375
Chargement…
Il n'existe pas encore de contenu.