Improve search UI #375

Scalone

elegaanz scala 2 commity/ów z search-ui do master

elegaanz skomentował(-a) (Zmigrowane z github.com)

Add a link to the search page in the header
Translate it

I also removed placeholders because there were not adding much value, and were making the code harder to read when translated (I don't know if it was really a good idea, maybe we should keep them ?).

- Add a link to the search page in the header - Translate it I also removed placeholders because there were not adding much value, and were making the code harder to read when translated (I don't know if it was really a good idea, maybe we should keep them ?).

trinity-1686a skomentował(-a)

Właściciel

Whoops all this got totally off my mind. I don't like where is placed the search button when connected, but I see no better place to put it. Concerning placeholders, I think it feel a bit empty without them 😐

codecov[bot] skomentował(-a) (Zmigrowane z github.com)

Codecov Report

Merging #375 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage    28.3%   28.27%   -0.03%     
==========================================
  Files          63       63              
  Lines        5949     5955       +6     
==========================================
  Hits         1684     1684              
- Misses       4265     4271       +6

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/375?src=pr&el=h1) Report > Merging [#375](https://codecov.io/gh/Plume-org/Plume/pull/375?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/fdfeeed6d9fa9dec92862366a8b646eb27d17422?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #375 +/- ## ========================================== - Coverage 28.3% 28.27% -0.03% ========================================== Files 63 63 Lines 5949 5955 +6 ========================================== Hits 1684 1684 - Misses 4265 4271 +6 ```

codecov[bot] skomentował(-a) (Zmigrowane z github.com)

Codecov Report

Merging #375 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   27.64%   27.62%   -0.03%     
==========================================
  Files          63       63              
  Lines        7336     7342       +6     
==========================================
  Hits         2028     2028              
- Misses       5308     5314       +6

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/375?src=pr&el=h1) Report > Merging [#375](https://codecov.io/gh/Plume-org/Plume/pull/375?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a2ddfb0ee91c575bb0d9c1d42944a78e75f9669f?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #375 +/- ## ========================================== - Coverage 27.64% 27.62% -0.03% ========================================== Files 63 63 Lines 7336 7342 +6 ========================================== Hits 2028 2028 - Misses 5308 5314 +6 ```

elegaanz skomentował(-a) (Zmigrowane z github.com)

Ok, I'll had placeholders back. And for the button, maybe putting it before the Dashboard button?

trinity-1686a skomentował(-a)

Właściciel

I tried, it's maybe a bit better. I think my issue is there start to be maybe too many buttons here, maybe replacing the /me link with a drop-down where you can also logout and see your dashboard? But that would need it's own pr I think

👍 1

trinity-1686a zatwierdza te zmiany

trinity-1686a zostawił komentarz

Właściciel

sorry to react so late, I did not notice you added placeholders back while merging before

elegaanz skomentował(-a) (Zmigrowane z github.com)

No problem. 🙂

No problem. :slightly_smiling_face:

Recenzenci

trinity-1686a zatwierdza te zmiany

Pull Request został scalony jako 5880dc1957.

Możesz także zobaczyć instrukcje wiersza poleceń.

Krok 1:

Z repozytorium twojego projektu, sprawdź nową gałąź i przetestuj zmiany.

git checkout -b search-ui master

git pull origin search-ui

Krok 2:

Połącz zmiany i zaktualizuj na Forgejo.

git checkout master

git merge --no-ff search-ui

git push origin master

Zaloguj się, aby dołączyć do tej rozmowy.

Brak recenzentów

Brak kamienia milowego

Brak przypisanych

Uczestnicy 2

Powiadomienia

Termin realizacji

Data realizacji jest niewłaściwa lub spoza zakresu. Użyj formatu 'yyyy-mm-dd'.

Brak ustawionego terminu realizacji.

Zależności

No dependencies set.

Ładowanie…

Nie ma jeszcze treści.

Etykiety Kamienie milowe

Improve search UI #375

Codecov Report

Codecov Report

Recenzenci

Krok 1:

Krok 2: