Improve search UI #375

已合併
elegaanz 將 2 次提交從 search-ui 合併至 master 5 年前
elegaanz 已留言 5 年前 (已從 github.com 遷移)
  • Add a link to the search page in the header
  • Translate it

I also removed placeholders because there were not adding much value, and were making the code harder to read when translated (I don't know if it was really a good idea, maybe we should keep them ?).

- Add a link to the search page in the header - Translate it I also removed placeholders because there were not adding much value, and were making the code harder to read when translated (I don't know if it was really a good idea, maybe we should keep them ?).
擁有者

Whoops all this got totally off my mind. I don't like where is placed the search button when connected, but I see no better place to put it. Concerning placeholders, I think it feel a bit empty without them 😐

Whoops all this got totally off my mind. I don't like where is placed the search button when connected, but I see no better place to put it. Concerning placeholders, I think it feel a bit empty without them :neutral_face:
codecov[bot] 已留言 5 年前 (已從 github.com 遷移)

Codecov Report

Merging #375 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage    28.3%   28.27%   -0.03%     
==========================================
  Files          63       63              
  Lines        5949     5955       +6     
==========================================
  Hits         1684     1684              
- Misses       4265     4271       +6
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/375?src=pr&el=h1) Report > Merging [#375](https://codecov.io/gh/Plume-org/Plume/pull/375?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/fdfeeed6d9fa9dec92862366a8b646eb27d17422?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #375 +/- ## ========================================== - Coverage 28.3% 28.27% -0.03% ========================================== Files 63 63 Lines 5949 5955 +6 ========================================== Hits 1684 1684 - Misses 4265 4271 +6 ```
codecov[bot] 已留言 5 年前 (已從 github.com 遷移)

Codecov Report

Merging #375 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   27.64%   27.62%   -0.03%     
==========================================
  Files          63       63              
  Lines        7336     7342       +6     
==========================================
  Hits         2028     2028              
- Misses       5308     5314       +6
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/375?src=pr&el=h1) Report > Merging [#375](https://codecov.io/gh/Plume-org/Plume/pull/375?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/a2ddfb0ee91c575bb0d9c1d42944a78e75f9669f?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #375 +/- ## ========================================== - Coverage 27.64% 27.62% -0.03% ========================================== Files 63 63 Lines 7336 7342 +6 ========================================== Hits 2028 2028 - Misses 5308 5314 +6 ```
elegaanz 已留言 5 年前 (已從 github.com 遷移)

Ok, I'll had placeholders back. And for the button, maybe putting it before the Dashboard button?

Ok, I'll had placeholders back. And for the button, maybe putting it before the Dashboard button?
擁有者

I tried, it's maybe a bit better. I think my issue is there start to be maybe too many buttons here, maybe replacing the /me link with a drop-down where you can also logout and see your dashboard? But that would need it's own pr I think

I tried, it's maybe a bit better. I think my issue is there start to be maybe too many buttons here, maybe replacing the /me link with a drop-down where you can also logout and see your dashboard? But that would need it's own pr I think
trinity-1686a 核可了這些變更 5 年前
trinity-1686a 留下了回應
擁有者

sorry to react so late, I did not notice you added placeholders back while merging before

sorry to react so late, I did not notice you added placeholders back while merging before
elegaanz 已留言 5 年前 (已從 github.com 遷移)

No problem. 🙂

No problem. :slightly_smiling_face:

審核者

trinity-1686a 核可了這些變更 5 年前
此合併請求已被合併為 5880dc1957
您也可以查看命令列指南

第一步:

在您的儲存庫中切換到新分支並測試變更。
git checkout -b search-ui master
git pull origin search-ui

第二步:

合併變更並更新到 Forgejo。
git checkout master
git merge --no-ff search-ui
git push origin master
登入 才能加入這對話。
沒有審核者
未選擇里程碑
沒有負責人
2 參與者
通知
截止日期
截止日期無效或超出範圍,請使用「yyyy-mm-dd」的格式。

未設定截止日期。

先決條件

未設定先決條件。

參考: Plume/Plume#375
載入中…
尚未有任何內容