#417 Better contrast for input fields

Merged
dfeyer merged 3 commits from task-better-inputs into master 1 year ago
dfeyer commented 1 year ago (Migrated from github.com)

This change set a white background for input field (text, select and textarea)
to have a better contrast with the page background and improve accessibility for
people with vision problem, and just crappy screen.

This change also remove the round corner for the input to have a clear difference
between editing field and buttons.

This max-width of the form element are a bit bigger too.

This change set a white background for input field (text, select and textarea) to have a better contrast with the page background and improve accessibility for people with vision problem, and just crappy screen. This change also remove the round corner for the input to have a clear difference between editing field and buttons. This max-width of the form element are a bit bigger too.
dfeyer commented 1 year ago (Migrated from github.com)
Owner

Screenshot are better than a long description

image

Screenshot are better than a long description ![image](https://user-images.githubusercontent.com/221173/50851373-efb50080-137c-11e9-8211-ebac3dae5489.png)
dfeyer (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

This will enforce the max-width for all element inside so we don’t have to define the max-width for every element that can be used in a form element

This will enforce the max-width for all element inside so we don't have to define the max-width for every element that can be used in a form element
Plume_migration_agent commented 1 year ago

I don’t have the full history of the project so I don’t know why you use a different box sizing here ?

I don't have the full history of the project so I don't know why you use a different box sizing here ?
@@ -49,3 +49,3 @@
body > main > *, .h-feed > * {
padding: 0 20%;
margin: 0 20%;
}
Plume_migration_agent commented 1 year ago

Needed to set the max-width on form element, should not break anything

Needed to set the max-width on form element, should not break anything
dfeyer commented 1 year ago (Migrated from github.com)
Owner

I forgot to say that the margin between to label and the input are smaller with this change, to make the block (label+input/textarea) more “solid”.

An other issue we have here is the too low color contrast between the help text/button and the background, will try to solve this in an other PR

I forgot to say that the margin between to label and the input are smaller with this change, to make the block (label+input/textarea) more "solid". An other issue we have here is the too low color contrast between the help text/button and the background, will try to solve this in an other PR
elegaanz (Migrated from github.com) approved these changes 1 year ago
elegaanz (Migrated from github.com) left a comment

Thanks a lot! It indeed greatly improves contrast. My only concern is that buttons seem a bit inconsistent with the rest of the design now, since they are the only elements with slightly rounded corners (everything else has sharp angles, expecting avatars that are totally rounded). Otherwise it looks great! Thanks again.

Plume_migration_agent commented 1 year ago

I don’t remember either 😅

I don't remember either :sweat_smile:
@@ -49,3 +49,3 @@
body > main > *, .h-feed > * {
padding: 0 20%;
margin: 0 20%;
}
Plume_migration_agent commented 1 year ago

I think it broke the article list on the profile page, but that’s not a real problem. However if you want to fix it, just replace padding with margin in .cards too.

I think it broke the article list on the profile page, but that's not a real problem. However if you want to fix it, just replace `padding` with `margin` in `.cards` too.
Plume_migration_agent commented 1 year ago

(and actually it is not broken, just different from what we currently have)

(and actually it is not broken, just different from what we currently have)
dfeyer commented 1 year ago (Migrated from github.com)
Owner

My only concern is that buttons seem a bit inconsistent

@BaptisteGelez Button are my next topic, will need a better visual language to make them different from input, but not too much. Maybe playing with the height of the element, and use plume violet color for the primary action as a background color. Will push an other PR when my design research are more advanced, will try to prototype on figma and share the design here before the implementation.

> My only concern is that buttons seem a bit inconsistent @BaptisteGelez Button are my next topic, will need a better visual language to make them different from input, but not too much. Maybe playing with the height of the element, and use plume violet color for the primary action as a background color. Will push an other PR when my design research are more advanced, will try to prototype on figma and share the design here before the implementation.
elegaanz commented 1 year ago (Migrated from github.com)
Owner

Okay! Then unless you want to fix this little “issue”: https://github.com/Plume-org/Plume/pull/417#discussion_r246444928 I will merge this PR (but I’m totally fine merging it as it is if you don’t want to take the time to do the change, I completely understand).

Okay! Then unless you want to fix this little "issue": https://github.com/Plume-org/Plume/pull/417#discussion_r246444928 I will merge this PR (but I'm totally fine merging it as it is if you don't want to take the time to do the change, I completely understand).
dfeyer commented 1 year ago (Migrated from github.com)
Owner

Let’s merge this one, and I can fix the margin of cards in an other PR, I hate swapping padding / margin all the time, so maybe we can found a cleaner solution.

Let's merge this one, and I can fix the margin of cards in an other PR, I hate swapping padding / margin all the time, so maybe we can found a cleaner solution.
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #417 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #417   +/-   ##
=======================================
  Coverage   27.64%   27.64%           
=======================================
  Files          63       63           
  Lines        7336     7336           
=======================================
  Hits         2028     2028           
  Misses       5308     5308
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/417?src=pr&el=h1) Report > Merging [#417](https://codecov.io/gh/Plume-org/Plume/pull/417?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/0490b698cbab7833b171e684bd9f47bbc1260407?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #417 +/- ## ======================================= Coverage 27.64% 27.64% ======================================= Files 63 63 Lines 7336 7336 ======================================= Hits 2028 2028 Misses 5308 5308 ```

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as 09a26b4602.
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.