Better header line height #418

2019-01-08T23:02:11Z

dfeyer hat

2019-01-08 23:02:11 +00:00

kommentiert (Migriert von github.com)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

👍 1

igalic (Migriert von github.com) hat 2019-01-08 23:49:30 +00:00 gereviewt

igalic (Migriert von github.com) hat einen Kommentar hinterlassen

❓

static/css/_article.scss

					
				@ -18,3 +18,3 @@

				 	font-size: 1.2em;

				 	line-height: 1.7em;

				 	line-height: 1.7;

igalic (Migriert von github.com) hat

2019-01-08 23:48:32 +00:00

kommentiert

what's the measure without a postfix?

dfeyer (Migriert von github.com) hat 2019-01-09 12:30:54 +00:00 gereviewt

static/css/_article.scss

					
				@ -18,3 +18,3 @@

				 	font-size: 1.2em;

				 	line-height: 1.7em;

				 	line-height: 1.7;

dfeyer (Migriert von github.com) hat

2019-01-09 12:30:53 +00:00

kommentiert

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the `main article`selector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size. Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable. See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

elegaanz (Migriert von github.com) hat die Änderungen 2019-01-09 16:45:40 +00:00 genehmigt

elegaanz (Migriert von github.com) hat einen Kommentar hinterlassen

Thanks!

Anmelden, um an der Diskussion teilzunehmen.

Keine Reviewer

elegaanz

Kein Meilenstein

Kein Projekt

Niemand zuständig

1 Beteiligter

Nachrichten

Fällig am

Das Fälligkeitsdatum ist ungültig oder außerhalb des zulässigen Bereichs. Bitte verwende das Format „jjjj-mm-tt“.

Kein Fälligkeitsdatum gesetzt.

Abhängigkeiten

Keine Abhängigkeiten gesetzt.

Referenz: Plume/Plume#418

Zeilen
Spalten