Better header line height #418

Fusionado
dfeyer fusionó 2 commits de task-better-header en master 2019-01-09 16:46:04 +00:00
dfeyer comentado 2019-01-08 23:02:11 +00:00 (Migrado desde github.com)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)
igalic (Migrado desde github.com) revisó 2019-01-08 23:49:30 +00:00
igalic (Migrado desde github.com) dejó un comentario

@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;
igalic (Migrado desde github.com) comentado 2019-01-08 23:48:32 +00:00

what's the measure without a postfix?

what's the measure without a postfix?
dfeyer (Migrado desde github.com) revisó 2019-01-09 12:30:54 +00:00
@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;
dfeyer (Migrado desde github.com) comentado 2019-01-09 12:30:53 +00:00

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the `main article`selector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size. Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable. See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0
elegaanz (Migrado desde github.com) aprobó estos cambios 2019-01-09 16:45:40 +00:00
elegaanz (Migrado desde github.com) dejó un comentario

Thanks!

Thanks!
Inicie sesión para unirse a esta conversación.
No hay revisores
Sin hito
Ningún proyecto
Sin encargados
1 participante
Notificaciones
Fecha límite
La fecha límite es inválida o está fuera de rango. Por favor utiliza el formato "aaaa-mm-dd".

Fecha límite no definida.

Dependencias

No se han establecido dependencias.

Referencia: Plume/Plume#418
No se ha proporcionado una descripción.