#418 Better header line height

Fusionnée
dfeyer a fusionné 2 révision(s) à partir de task-better-header vers master il y a 2 ans
dfeyer a commenté il y a 2 ans (Migré de github.com)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)
igalic (Migré de github.com) révisé il y a 2 ans
igalic (Migré de github.com) laisser un commentaire

@@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;

Plume_migration_agent a commenté il y a 2 ans

what’s the measure without a postfix?

what's the measure without a postfix?
dfeyer (Migré de github.com) révisé il y a 2 ans
@@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;

Plume_migration_agent a commenté il y a 2 ans

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the `main article`selector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size. Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable. See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0
elegaanz (Migré de github.com) ces changements ont été approuvés il y a 2 ans
elegaanz (Migré de github.com) laisser un commentaire

Thanks!

Relecteurs

Plume_migration_agent ces changements ont été approuvés il y a 2 ans
La demande de tirage a été fusionnée en 671c340aa8.
Connectez-vous pour rejoindre cette conversation.
Pas de relecteur
Aucun jalon
Pas d'assignataires
1 participants
Notifications
Échéance

Aucune échéance n'a été définie.

Dépendances

La demande de fusion n'a actuellement pas de dépendance.

Chargement…
Il n'existe pas encore de contenu.