#418 Better header line height

マージ済み
dfeyer が 2 個のコミットを task-better-header から master へマージ 2年前
dfeyer 2年前 にコメント (github.comから移行)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)
igalic (github.comから移行) がレビュー 2年前
igalic (github.comから移行) がコメント

@@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;

Plume_migration_agent2年前 にコメント

what’s the measure without a postfix?

what's the measure without a postfix?
dfeyer (github.comから移行) がレビュー 2年前
@@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;

Plume_migration_agent2年前 にコメント

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the `main article`selector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size. Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable. See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0
elegaanz (github.comから移行) が変更を承認 2年前
elegaanz (github.comから移行) がコメント

Thanks!

レビューア

Plume_migration_agent が変更を承認 2年前
プルリクエストは 671c340aa8 でマージされています。
サインインしてこの会話に参加。
レビューアなし
マイルストーンなし
担当者なし
1 人の参加者
通知
期日

期日は未設定です。

依存関係

このプルリクエストに依存関係はありません。

読み込み中…
まだ内容がありません