Better header line height #418

2019-01-08T23:02:11Z

dfeyer がコメント

2019-01-08 23:02:11 +00:00

(github.comから移行)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

👍 1

igalic (github.comから移行) がレビュー 2019-01-08 23:49:30 +00:00

igalic (github.comから移行) がコメント

❓

static/css/_article.scss

					
				@ -18,3 +18,3 @@

				 	font-size: 1.2em;

				 	line-height: 1.7em;

				 	line-height: 1.7;

igalic (github.comから移行) がコメント

2019-01-08 23:48:32 +00:00

what's the measure without a postfix?

dfeyer (github.comから移行) がレビュー 2019-01-09 12:30:54 +00:00

static/css/_article.scss

					
				@ -18,3 +18,3 @@

				 	font-size: 1.2em;

				 	line-height: 1.7em;

				 	line-height: 1.7;

dfeyer (github.comから移行) がコメント

2019-01-09 12:30:53 +00:00

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the `main article`selector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size. Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable. See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

elegaanz (github.comから移行) が変更を承認 2019-01-09 16:45:40 +00:00

elegaanz (github.comから移行) がコメント

Thanks!

サインインしてこの会話に参加。

レビューアなし

elegaanz

マイルストーンなし

プロジェクトなし

担当者なし

1 人の参加者

通知

期日

期日が正しくないか範囲を超えています。 "yyyy-mm-dd" の形式で入力してください。

期日は未設定です。

依存関係

依存関係が設定されていません。

リファレンス: Plume/Plume#418

Rows
Columns