Better header line height #418

2019-01-08T23:02:11Z

dfeyer 코멘트함,

2019-01-08 23:02:11 +00:00

(Migrated from github.com)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

👍 1

igalic (Migrated from github.com) 검토됨 2019-01-08 23:49:30 +00:00

igalic (Migrated from github.com) left a comment

❓

static/css/_article.scss

					
				@ -18,3 +18,3 @@

				 	font-size: 1.2em;

				 	line-height: 1.7em;

				 	line-height: 1.7;

igalic (Migrated from github.com) 코멘트함,

2019-01-08 23:48:32 +00:00

what's the measure without a postfix?

dfeyer (Migrated from github.com) 검토됨 2019-01-09 12:30:54 +00:00

static/css/_article.scss

					
				@ -18,3 +18,3 @@

				 	font-size: 1.2em;

				 	line-height: 1.7em;

				 	line-height: 1.7;

dfeyer (Migrated from github.com) 코멘트함,

2019-01-09 12:30:53 +00:00

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the `main article`selector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size. Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable. See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

elegaanz (Migrated from github.com) 이 변경사항을 승인함 2019-01-09 16:45:40 +00:00

elegaanz (Migrated from github.com) left a comment

Thanks!

로그인하여 이 대화에 참여하세요.

No reviewers

elegaanz

마일스톤 없음

프로젝트 없음

담당자 없음

참가자 1명

알림

마감일

기한이 올바르지 않거나 범위를 벗어났습니다. "yyyy-mm-dd"형식을 사용해주십시오.

마감일이 설정되지 않았습니다.

전제조건

전제조건이 설정되지 않았습니다.

Reference: Plume/Plume#418

행
열