#418 Better header line height

병합
dfeyer task-better-header 에서 master 로 2 commits 를 머지했습니다 2 년 전
dfeyer 코멘트됨, 2 년 전 (Migrated from github.com)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)
igalic (Migrated from github.com) 검토됨 2 년 전
igalic (Migrated from github.com) left a comment

@@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;

Plume_migration_agent 코멘트됨, 2 년 전

what’s the measure without a postfix?

what's the measure without a postfix?
dfeyer (Migrated from github.com) 검토됨 2 년 전
@@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;

Plume_migration_agent 코멘트됨, 2 년 전

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the `main article`selector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size. Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable. See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0
elegaanz (Migrated from github.com) 이 변경사항을 승인하였습니다. 2 년 전
elegaanz (Migrated from github.com) left a comment

Thanks!

리뷰어

Plume_migration_agent 이 변경사항을 승인하였습니다. 2 년 전
The pull request has been merged as 671c340aa8.
로그인하여 이 대화에 참여
마일스톤 없음
담당자 없음
참여자 1명
알림
마감일

마감일이 설정되지 않았습니다.

의존성

이 풀 리퀘스트는 어떠한 의존성도 가지지 않습니다.

불러오는 중...
아직 콘텐츠가 없습니다.