Plume/Plume
9
18
Atzarojums 24
Kods Pieteikumi 177 Izmaiņu pieprasījumi 8 Laidieni 8 Vikivietne Notikumi

Better header line height #418

Apvienots
dfeyer Iekļāva 2 iesūtījumus no task-better-header zarā master 2019-01-09 16:46:04 +00:00
Saruna 0 Iesūtījumi 2 Izmainītās datnes 3 +25 -9
dfeyer pievienoja piebildi 2019-01-08 23:02:11 +00:00 (Pārcelta no github.com)
Ievietot saiti starpliktuvē

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)
👍 1
igalic (Pārcelta no github.com) izskatīja 2019-01-08 23:49:30 +00:00
igalic (Pārcelta no github.com) pievienoja piebildi
Ievietot saiti starpliktuvē

❓

❓
static/css/_article.scss
@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;
igalic (Pārcelta no github.com) pievienoja piebildi 2019-01-08 23:48:32 +00:00
Ievietot saiti starpliktuvē

what's the measure without a postfix?

what's the measure without a postfix?
dfeyer (Pārcelta no github.com) izskatīja 2019-01-09 12:30:54 +00:00
static/css/_article.scss
@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;
dfeyer (Pārcelta no github.com) pievienoja piebildi 2019-01-09 12:30:53 +00:00
Ievietot saiti starpliktuvē

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the `main article`selector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size. Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable. See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0
elegaanz (Pārcelta no github.com) apstiprināja šīs izmaiņas 2019-01-09 16:45:40 +00:00
elegaanz (Pārcelta no github.com) pievienoja piebildi
Ievietot saiti starpliktuvē

Thanks!

Thanks!
Nepieciešams pieteikties, lai pievienotos šai sarunai.
Izskatītāji
Nav izskatītāju
elegaanz
Iezīmes
Notīrīt iezīmes   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

Nav iezīmju
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Atskaites punkts
Notīrīt atskaites punktus
Nav neviena ieraksta
Nav atskaites punkta
Projekti
Notīrīt projektus
Nav neviena ieraksta
Nav projektu
Atbildīgie
Noņemt atbildīgo
Nav atbildīgo
1 dalībnieks
Paziņojumi
Izpildes datums
Izpildes datums nav derīgs vai tas ir ārpus datumu apgabala. Lūgums izmantot pierakstu "gggg-mm-dd".

Nav uzstādīts izpildes datums.

Atkarības

Nav atkarību.

Atsauce: Plume/Plume#418
Nav sniegts apraksts.
Izdzēst zaru "task-better-header"

Zara izdzēšana ir neatgriezeniska. Kaut arī izdzēstais zars neilgu laiku var turpināt pastāvēt, pirms tas patiešām tiek noņemts, to vairumā gadījumu NEVAR atsaukt. Turpināt?