#418 Better header line height

Sapludināts
dfeyer sapludināja 2 revīzijas no task-better-header uz master pirms 2 gadiem
dfeyer komentēja pirms 2 gadiem (Migrēts no github.com)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)
igalic (Migrēts no github.com) recenzēja pirms 2 gadiem
igalic (Migrēts no github.com) atstāja komentāru

@@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;

Plume_migration_agent komentēja pirms 2 gadiem

what’s the measure without a postfix?

what's the measure without a postfix?
dfeyer (Migrēts no github.com) recenzēja pirms 2 gadiem
@@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;

Plume_migration_agent komentēja pirms 2 gadiem

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the `main article`selector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size. Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable. See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0
elegaanz (Migrēts no github.com) apstiprināja izmaiņas pirms 2 gadiem
elegaanz (Migrēts no github.com) atstāja komentāru

Thanks!

Recenzenti

Plume_migration_agent apstiprināja izmaiņas pirms 2 gadiem
Izmaiņu pieprasījums tika sapludināts ar revīziju 671c340aa8.
Pierakstieties, lai pievienotos šai sarunai.
Nav recenzentu
Nav atskaites punktu
Nav atbildīgo
1 dalībnieki
Paziņojumi
Izpildes termiņš

Izpildes termiņš nav uzstādīts.

Atkarības

Šim izmaiņu pieprasījumam pagaidām nav nevienas atkarības.

Notiek ielāde…
Vēl nav satura.