Better header line height #418

2019-01-08T23:02:11Z

dfeyer reageerde

2019-01-08 23:02:11 +00:00

(Gemigreerd van github.com)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

👍 1

igalic (Gemigreerd van github.com) beoordeeld 2019-01-08 23:49:30 +00:00

igalic (Gemigreerd van github.com) heeft een reactie achtergelaten

❓

static/css/_article.scss

					
				@ -18,3 +18,3 @@

				 	font-size: 1.2em;

				 	line-height: 1.7em;

				 	line-height: 1.7;

igalic (Gemigreerd van github.com) reageerde

2019-01-08 23:48:32 +00:00

what's the measure without a postfix?

dfeyer (Gemigreerd van github.com) beoordeeld 2019-01-09 12:30:54 +00:00

static/css/_article.scss

					
				@ -18,3 +18,3 @@

				 	font-size: 1.2em;

				 	line-height: 1.7em;

				 	line-height: 1.7;

dfeyer (Gemigreerd van github.com) reageerde

2019-01-09 12:30:53 +00:00

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the `main article`selector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size. Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable. See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

elegaanz (Gemigreerd van github.com) heeft deze veranderingen 2019-01-09 16:45:40 +00:00 goedgekeurd

elegaanz (Gemigreerd van github.com) heeft een reactie achtergelaten

Thanks!

Log in om deel te nemen aan deze discussie.

Geen beoordelaars

elegaanz

Geen mijlpaal

Geen project

Niet toegewezen

1 deelnemer

Notificaties

Vervaldatum

De deadline is ongeldig of buiten bereik. Gebruik het formaat "jjjj-mm-dd'.

Geen vervaldatum ingesteld.

Afhankelijkheden

Geen afhankelijkheden ingesteld.

Referentie: Plume/Plume#418

Rijen
Kolommen