#418 Better header line height

Scalone
dfeyer scala 2 commity/ów z task-better-header do master 2 lat temu
dfeyer skomentował(-a) 2 lat temu (Zmigrowane z github.com)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)
igalic (Zmigrowane z github.com) zrecenzowano 2 lat temu
igalic (Zmigrowane z github.com) zostawił komentarz

@@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;

Plume_migration_agent skomentował(-a) 2 lat temu

what’s the measure without a postfix?

what's the measure without a postfix?
dfeyer (Zmigrowane z github.com) zrecenzowano 2 lat temu
@@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;

Plume_migration_agent skomentował(-a) 2 lat temu

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the `main article`selector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size. Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable. See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0
elegaanz (Zmigrowane z github.com) zatwierdza te zmiany 2 lat temu
elegaanz (Zmigrowane z github.com) zostawił komentarz

Thanks!

Recenzenci

Plume_migration_agent zatwierdza te zmiany 2 lat temu
Pull Request został scalony jako 671c340aa8.
Zaloguj się, aby dołączyć do tej rozmowy.
Brak recenzentów
Brak kamienia milowego
Brak przypisanych
Uczestnicy 1
Powiadomienia
Termin realizacji

Brak ustawionego terminu realizacji.

Zależności

Ten Pull Request nie zawiera w tej chwili żadnych zależności.

Ładowanie…
Nie ma jeszcze treści.