#418 Better header line height

Merge aplicado
dfeyer aplicou merge dos 2 commits de task-better-header em master 2 anos atrás
dfeyer comentou 2 anos atrás (Migrado de github.com)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)
igalic (Migrado de github.com) revisou 2 anos atrás
igalic (Migrado de github.com) left a comment

@@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;

Plume_migration_agent comentou 2 anos atrás

what’s the measure without a postfix?

what's the measure without a postfix?
dfeyer (Migrado de github.com) revisou 2 anos atrás
@@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;

Plume_migration_agent comentou 2 anos atrás

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the `main article`selector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size. Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable. See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0
elegaanz (Migrado de github.com) aprovou estas alterações 2 anos atrás
elegaanz (Migrado de github.com) left a comment

Thanks!

Revisores

Plume_migration_agent aprovou estas alterações 2 anos atrás
O pull request teve merge aplicado como 671c340aa8.
Acesse para participar desta conversação.
Sem marco
Sem responsável
1 participante(s)
Notificações
Data limite

Data limite não informada.

Dependências

Atualmente este pull request não tem dependências.

Carregando…
Ainda não há conteúdo.