Plume/Plume
9
18
Derivar 24
Código Questões 177 Pedidos de integração 8 Lançamentos 8 Wiki Trabalho

Better header line height #418

Integrado
dfeyer integrou 2 cometimento(s) do ramo task-better-header no ramo master 2019-01-09 16:46:04 +00:00
Diálogo 0 Cometimentos 2 Ficheiros modificados 3 +25 -9
dfeyer comentou 2019-01-08 23:02:11 +00:00 (Migrado de github.com)
Copiar ligação

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)
👍 1
igalic (Migrado de github.com) reviu 2019-01-08 23:49:30 +00:00
igalic (Migrado de github.com) deixou um comentário
Copiar ligação

❓

❓
static/css/_article.scss
@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;
igalic (Migrado de github.com) comentou 2019-01-08 23:48:32 +00:00
Copiar ligação

what's the measure without a postfix?

what's the measure without a postfix?
dfeyer (Migrado de github.com) reviu 2019-01-09 12:30:54 +00:00
static/css/_article.scss
@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;
dfeyer (Migrado de github.com) comentou 2019-01-09 12:30:53 +00:00
Copiar ligação

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the `main article`selector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size. Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable. See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0
elegaanz (Migrado de github.com) aprovou estas modificações 2019-01-09 16:45:40 +00:00
elegaanz (Migrado de github.com) deixou um comentário
Copiar ligação

Thanks!

Thanks!
Inicie a sessão para participar neste diálogo.
Revisores
Sem revisores
elegaanz
Rótulos
Retirar rótulos   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

Sem rótulos
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Etapa
Limpar etapa
Sem itens
Sem etapa
Planeamentos
Limpar planeamentos
Sem itens
Nenhum planeamento
Encarregados
Retirar todos os encarregados
Sem encarregados
1 participante
Notificações
Data de vencimento
A data de vencimento é inválida ou está fora do intervalo permitido. Por favor, use o formato "aaaa-mm-dd".

Sem data de vencimento definida.

Dependências

Não estão definidas dependências.

Referência: Plume/Plume#418
Nenhuma descrição fornecida.
Eliminar o ramo "task-better-header"

Eliminar um ramo é algo permanente. Embora o ramo eliminado possa continuar a existir por um breve período de tempo antes de ser realmente removido, a operação NÃO PODERÁ ser desfeita na maioria dos casos. Quer continuar?