#418 Better header line height

Integração executada
dfeyer integrou 2 cometimentos de %!<(string=task-better-header)/code> em master há 2 anos
dfeyer comentado há 2 anos (Migrado de github.com)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)
igalic (Migrado de github.com) reviu há 2 anos
igalic (Migrado de github.com) deixou um comentário

@@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;

Plume_migration_agent comentado há 2 anos

what’s the measure without a postfix?

what's the measure without a postfix?
dfeyer (Migrado de github.com) reviu há 2 anos
@@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;

Plume_migration_agent comentado há 2 anos

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the `main article`selector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size. Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable. See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0
elegaanz (Migrado de github.com) aprovou estas alterações há 2 anos
elegaanz (Migrado de github.com) deixou um comentário

Thanks!

Revisores

Plume_migration_agent aprovou estas alterações há 2 anos
A integração constante no pedido foi executada como 671c340aa8.
Inicie a sessão para participar neste diálogo.
Sem revisores
Sem etapa
Sem responsáveis
1 Participantes
Notificações
Date limite

Sem data limite definida.

Dependências

Este pedido de integração não tem quaisquer dependências, neste momento.

Carregando…
Ainda não há conteúdo.