#418 Better header line height

Sammanfogat
dfeyer sammanfogade 2 incheckningar från task-better-header in i master 2 år sedan
dfeyer kommenterad 2 år sedan (Migrerad från github.com)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)
igalic (Migrerad från github.com) granskad av 2 år sedan
igalic (Migrerad från github.com) lämnade en kommentar

@@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;

Plume_migration_agent kommenterad 2 år sedan

what’s the measure without a postfix?

what's the measure without a postfix?
dfeyer (Migrerad från github.com) granskad av 2 år sedan
@@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;

Plume_migration_agent kommenterad 2 år sedan

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the `main article`selector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size. Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable. See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0
elegaanz (Migrerad från github.com) godkände dessa ändringar 2 år sedan
elegaanz (Migrerad från github.com) lämnade en kommentar

Thanks!

Granskare

Plume_migration_agent godkände dessa ändringar 2 år sedan
Pull-förfrågan har sammanfogats som 671c340aa8.
Logga in för att delta i denna konversation.
Inga granskare
Ingen Milsten
Ingen tilldelad
1 Deltagare
Notiser
Förfallodatum

Inget förfallodatum satt.

Beroenden

Denna pull-förfrågan har för närvarande inga beroenden.

Laddar…
Det finns inget innehåll än.