Better header line height #418
Inga granskare
Etiketter
Inga etiketter
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Ingen milstolpe
Inget projekt
Inga tilldelade
1 participant
Notiser
Förfallodatum
Inget förfallodatum satt.
Beroenden
No dependencies set.
Reference: Plume/Plume#418
Laddar…
Lägg till tabell
Hänvisa till i nytt ärende
No description provided.
Delete branch "task-better-header"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)
❓
@ -18,3 +18,3 @@font-size: 1.2em;line-height: 1.7em;line-height: 1.7;what's the measure without a postfix?
@ -18,3 +18,3 @@font-size: 1.2em;line-height: 1.7em;line-height: 1.7;line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the
main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.
See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0
Thanks!