Better header line height #418

Birleştirildi
dfeyer 2019-01-09 16:46:04 +00:00 task-better-header içindeki 2 işlemeyi master ile birleştirdi
dfeyer 2019-01-08 23:02:11 +00:00 yorum yaptı (github.com konumundan göç edildi)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)
igalic (github.com konumundan göç edildi) 2019-01-08 23:49:30 +00:00 incelendi
igalic (github.com konumundan göç edildi) bir yorum yaptı

@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;
igalic (github.com konumundan göç edildi) 2019-01-08 23:48:32 +00:00 yorum yaptı

what's the measure without a postfix?

what's the measure without a postfix?
dfeyer (github.com konumundan göç edildi) 2019-01-09 12:30:54 +00:00 incelendi
@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;
dfeyer (github.com konumundan göç edildi) 2019-01-09 12:30:53 +00:00 yorum yaptı

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the `main article`selector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size. Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable. See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0
elegaanz (github.com konumundan göç edildi) 2019-01-09 16:45:40 +00:00 bu değişiklikleri onayladı
elegaanz (github.com konumundan göç edildi) bir yorum yaptı

Thanks!

Thanks!
Bu konuşmaya katılmak için oturum aç.
Değerlendirici yok
Kilometre Taşı Yok
Proje yok
Atanan Kişi Yok
1 participant
Bildirimler
Bitiş Tarihi
Bitiş tarihi geçersiz veya aralık dışında. Lütfen 'yyyy-aa-gg' biçimini kullanın.

Bitiş tarihi atanmadı.

Bağımlılıklar

Bağımlılık yok.

Referans: Plume/Plume#418
Herhangi bir açıklama sağlanmadı.