Better header line height

Plume_migration_agent 评论于 2 年前

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

👍 1

igalic (从 github.com 迁移) 评审于 2 年前

❓

static/css/_article.scss

												
			@@ -18,3 +18,3 @@
		
			 	font-size: 1.2em;
		
			 	line-height: 1.7em;
		
			 	line-height: 1.7;

what’s the measure without a postfix?

dfeyer (从 github.com 迁移) 评审于 2 年前

elegaanz (从 github.com 迁移) 已于 2 年前批准这些更改

Thanks!

评审人

Plume_migration_agent 已于 2 年前批准这些更改

该合并请求已作为 671c340aa8 被合并。

登录并参与到对话中。

#418 Better header line height

评审人