#418 Better header line height

已合併
dfeyer 2 年之前 將 2 次代碼提交從 task-better-header合併至 master
dfeyer 評論 2 年之前 (Migrated from github.com)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)
igalic (Migrated from github.com) reviewed 2 年之前
igalic (Migrated from github.com) left a comment

@@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;

Plume_migration_agent 評論 2 年之前

what’s the measure without a postfix?

what's the measure without a postfix?
dfeyer (Migrated from github.com) reviewed 2 年之前
@@ -18,3 +18,3 @@
font-size: 1.2em;
line-height: 1.7em;
line-height: 1.7;

Plume_migration_agent 評論 2 年之前

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the `main article`selector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size. Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable. See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0
elegaanz (Migrated from github.com) approved these changes 2 年之前
elegaanz (Migrated from github.com) left a comment

Thanks!

Reviewers

Plume_migration_agent approved these changes 2 年之前
The pull request has been merged as 671c340aa8.
登入 才能加入這對話。
未選擇里程碑
No Assignees
1 參與者
訊息
截止日期

未設定截止日期。

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
尚未有任何內容