Better header line height #418

2019-01-08T23:02:11Z

dfeyer 已留言

2019-01-08 23:02:11 +00:00

(已從 github.com 遷移)

This change also remote all units for line-height to have more consistent styles and better cascading support. This solve the too small line height for multi line header in article and also add styling for h1 to h6 (previously h3 to h6 was not styled at all)

👍 1

igalic (已從 github.com 遷移) 已審核 2019-01-08 23:49:30 +00:00

igalic (已從 github.com 遷移) 留下了回應

❓

static/css/_article.scss

					
				@ -18,3 +18,3 @@

				 	font-size: 1.2em;

				 	line-height: 1.7em;

				 	line-height: 1.7;

igalic (已從 github.com 遷移) 已留言

2019-01-08 23:48:32 +00:00

what's the measure without a postfix?

dfeyer (已從 github.com 遷移) 已審核 2019-01-09 12:30:54 +00:00

static/css/_article.scss

					
				@ -18,3 +18,3 @@

				 	font-size: 1.2em;

				 	line-height: 1.7em;

				 	line-height: 1.7;

dfeyer (已從 github.com 遷移) 已留言

2019-01-09 12:30:53 +00:00

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the main articleselector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size.

Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable.

See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

line-height without postfix is based on the current font size (so a bit like em), but with the em postfix, cascading is based on the current font size, so the h1-6 get a line height of 1.7em based on the font size of the `main article`selector, so way too small. Without the postfix, element inside the article will have a correct line height, based on their own font size. Try to insert a really long headline in an article (to have a multi line rendering), with and without this PR to see that the headline are not readable. See for more details about the unitless value for line-height: https://css-tricks.com/almanac/properties/l/line-height/#article-header-id-0

elegaanz (已從 github.com 遷移) 核可了這些變更 2019-01-09 16:45:40 +00:00

elegaanz (已從 github.com 遷移) 留下了回應

Thanks!

登入才能加入這對話。

沒有審核者

elegaanz

沒有里程碑

未選擇專案

沒有負責人

1 位參與者

通知

截止日期

截止日期無效或超出範圍，請使用「yyyy-mm-dd」的格式。

未設定截止日期。

先決條件

未設定先決條件。

參考: Plume/Plume#418

列
欄