Plume
/
Plume
8
16
フォーク 22
コード イシュー 174 プルリクエスト 8 リリース 8 Wiki アクティビティ

ラベル マイルストーン

Add a page listing people someone follows #444

マージ済み
elegaanz が 5 個のコミットを follows-page から master へマージ 5年前
会話 2 コミット 5 変更されたファイル 24
elegaanz がコメント 5年前 (github.comから移行)

Nothing exceptional, the layout is the same as the followers page.

Fixes #325

Nothing exceptional, the layout is the same as the followers page. Fixes #325
codecov[bot] がコメント 5年前 (github.comから移行)

Codecov Report

Merging #444 into master will increase coverage by 0.18%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
+ Coverage   25.58%   25.76%   +0.18%     
==========================================
  Files          63       63              
  Lines        6254     6477     +223     
==========================================
+ Hits         1600     1669      +69     
- Misses       4654     4808     +154
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/444?src=pr&el=h1) Report > Merging [#444](https://codecov.io/gh/Plume-org/Plume/pull/444?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/576a4ed49946545af1e2ef8db5058f840c05c8df?src=pr&el=desc) will **increase** coverage by `0.18%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #444 +/- ## ========================================== + Coverage 25.58% 25.76% +0.18% ========================================== Files 63 63 Lines 6254 6477 +223 ========================================== + Hits 1600 1669 +69 - Misses 4654 4808 +154 ```
trinity-1686a がレビュー 5年前
trinity-1686a がコメント
オーナー

👍

:+1:
igalic (github.comから移行) がレビュー 5年前
igalic (github.comから移行) がコメント

words are hard…

words are hard…
plume-models/src/users.rs
@ -580,0 +586,4 @@
.map_err(Error::from)
}
pub fn get_followed_page(&self, conn: &Connection, (min, max): (i32, i32)) -> Result<Vec<User>> {
igalic (github.comから移行) がコメント 5年前

n.b.: many people on the fediverse are not happy with the "clout" that comes from these numbers

do we offer an option to disable it?

i would also suggest considering "subscribe" instead of "follow".
it fits better with a blog, and has slightly less of a cult meaning

n.b.: many people on the fediverse are not happy with the "clout" that comes from these numbers do we offer an option to disable it? i would also suggest considering "subscribe" instead of "follow". it fits better with a blog, and has slightly less of a cult meaning
elegaanz (github.comから移行) がレビュー 5年前
plume-models/src/users.rs
@ -580,0 +586,4 @@
.map_err(Error::from)
}
pub fn get_followed_page(&self, conn: &Connection, (min, max): (i32, i32)) -> Result<Vec<User>> {
elegaanz (github.comから移行) がコメント 5年前

These numbers are not currently displayed in the UI, we only use this function to know how many pages listing followers/followed we need. If we display them one day, I totally agree that we should be able to hide them (maybe even hide them by default?), or that they should only be shown for your own profile.

And I agree on "follow"/"subscribe" too, I will change it. 🙂

These numbers are not currently displayed in the UI, we only use this function to know how many pages listing followers/followed we need. If we display them one day, I totally agree that we should be able to hide them (maybe even hide them by default?), or that they should only be shown for your own profile. And I agree on "follow"/"subscribe" too, I will change it. :slightly_smiling_face:
igalic (github.comから移行) がレビュー 5年前
igalic (github.comから移行) がコメント

🇩🇪 / 🇦🇹

🇩🇪 / 🇦🇹
po/plume/de.po
igalic (github.comから移行) がコメント 5年前

not quite… "Abonoment" would be a better translation.

not quite… "Abonoment" would be a better translation.
igalic (github.comから移行) がコメント 5年前

"Abonomenten"

"Abonomenten"
po/plume/de.po
@ -338,15 +341,19 @@ msgstr "Ändere dein Profil"
msgid "Open on {0}"
igalic (github.comから移行) がコメント 5年前

"abonieren"

"abonieren"
igalic (github.comから移行) がコメント 5年前

"abbestellen"

"abbestellen"
elegaanz (github.comから移行) がレビュー 5年前
po/plume/de.po
elegaanz (github.comから移行) がコメント 5年前

Yes, these strings have probably been automatically translated by GetText… 😕 I will edit them.

Yes, these strings have probably been automatically translated by GetText… :confused: I will edit them.
trinity-1686a がレビュー 5年前
trinity-1686a がコメント
オーナー

(there are still 7 times the word "follow" and it's derivative in translations, so I believe it must not be gone everywhere, but this is not the main point of this pr)

(there are still 7 times the word "follow" and it's derivative in translations, so I believe it must not be gone everywhere, but this is not the main point of this pr)
elegaanz がコメント 5年前 (github.comから移行)

I replaced the other occurrences of "follow" while we are at it.

I replaced the other occurrences of "follow" while we are at it.
trinity-1686a が変更を承認 5年前
trinity-1686a がコメント
オーナー

👍

:+1:

レビューア

trinity-1686a が変更を承認 5年前
プルリクエストは e28371bbe4 でマージされています。
コマンドラインの手順も確認できます。

ステップ 1:

あなたのプロジェクトリポジトリで新しいブランチをチェックアウトし、変更内容をテストします。
git checkout -b follows-page master
git pull origin follows-page

ステップ 2:

変更内容をマージして、Forgejoに反映します。
git checkout master
git merge --no-ff follows-page
git push origin master
サインインしてこの会話に参加。
レビューア
レビュー依頼
レビューアなし
trinity-1686a
ラベル
ラベル付け
ラベルをクリア   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
ラベルなし
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
マイルストーン
マイルストーンの設定
マイルストーンをクリア
項目なし
マイルストーンなし
担当者
担当者の割り当て
担当者をクリア
担当者なし
2 人の参加者
通知
期日
期日が正しくないか範囲を超えています。 'yyyy-mm-dd' の形式で入力してください。

期日は未設定です。

依存関係

依存関係が設定されていません。

リファレンス: Plume/Plume#444
書き込み プレビュー
読み込み中…
キャンセル
保存
まだ内容がありません
ブランチ 'follows-page' の削除

ブランチの削除は恒久的で、元に戻すことはできません。 続行しますか？

いいえ
はい