Plume
/
Plume
8
16
Vork 22
Code Kwesties 174 Pull-aanvragen 8 Publicaties 8 Wiki Activiteit

Labels Mijlpalen

Add a page listing people someone follows #444

Samengevoegd
elegaanz heeft 5 commits samengevoegd van follows-page naar master 5 jaren geleden
Discussie 2 Commits 5 Bestanden gewijzigd 24
elegaanz reageerde 5 jaren geleden (Gemigreerd van github.com)

Nothing exceptional, the layout is the same as the followers page.

Fixes #325

Nothing exceptional, the layout is the same as the followers page. Fixes #325
codecov[bot] reageerde 5 jaren geleden (Gemigreerd van github.com)

Codecov Report

Merging #444 into master will increase coverage by 0.18%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
+ Coverage   25.58%   25.76%   +0.18%     
==========================================
  Files          63       63              
  Lines        6254     6477     +223     
==========================================
+ Hits         1600     1669      +69     
- Misses       4654     4808     +154
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/444?src=pr&el=h1) Report > Merging [#444](https://codecov.io/gh/Plume-org/Plume/pull/444?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/576a4ed49946545af1e2ef8db5058f840c05c8df?src=pr&el=desc) will **increase** coverage by `0.18%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #444 +/- ## ========================================== + Coverage 25.58% 25.76% +0.18% ========================================== Files 63 63 Lines 6254 6477 +223 ========================================== + Hits 1600 1669 +69 - Misses 4654 4808 +154 ```
trinity-1686a beoordeeld 5 jaren geleden
trinity-1686a heeft een reactie achtergelaten
Eigenaar

👍

:+1:
igalic (Gemigreerd van github.com) beoordeeld 5 jaren geleden
igalic (Gemigreerd van github.com) heeft een reactie achtergelaten

words are hard…

words are hard…
plume-models/src/users.rs
@ -580,0 +586,4 @@
.map_err(Error::from)
}
pub fn get_followed_page(&self, conn: &Connection, (min, max): (i32, i32)) -> Result<Vec<User>> {
igalic (Gemigreerd van github.com) reageerde 5 jaren geleden

n.b.: many people on the fediverse are not happy with the "clout" that comes from these numbers

do we offer an option to disable it?

i would also suggest considering "subscribe" instead of "follow".
it fits better with a blog, and has slightly less of a cult meaning

n.b.: many people on the fediverse are not happy with the "clout" that comes from these numbers do we offer an option to disable it? i would also suggest considering "subscribe" instead of "follow". it fits better with a blog, and has slightly less of a cult meaning
elegaanz (Gemigreerd van github.com) beoordeeld 5 jaren geleden
plume-models/src/users.rs
@ -580,0 +586,4 @@
.map_err(Error::from)
}
pub fn get_followed_page(&self, conn: &Connection, (min, max): (i32, i32)) -> Result<Vec<User>> {
elegaanz (Gemigreerd van github.com) reageerde 5 jaren geleden

These numbers are not currently displayed in the UI, we only use this function to know how many pages listing followers/followed we need. If we display them one day, I totally agree that we should be able to hide them (maybe even hide them by default?), or that they should only be shown for your own profile.

And I agree on "follow"/"subscribe" too, I will change it. 🙂

These numbers are not currently displayed in the UI, we only use this function to know how many pages listing followers/followed we need. If we display them one day, I totally agree that we should be able to hide them (maybe even hide them by default?), or that they should only be shown for your own profile. And I agree on "follow"/"subscribe" too, I will change it. :slightly_smiling_face:
igalic (Gemigreerd van github.com) beoordeeld 5 jaren geleden
igalic (Gemigreerd van github.com) heeft een reactie achtergelaten

🇩🇪 / 🇦🇹

🇩🇪 / 🇦🇹
po/plume/de.po
igalic (Gemigreerd van github.com) reageerde 5 jaren geleden

not quite… "Abonoment" would be a better translation.

not quite… "Abonoment" would be a better translation.
igalic (Gemigreerd van github.com) reageerde 5 jaren geleden

"Abonomenten"

"Abonomenten"
po/plume/de.po
@ -338,15 +341,19 @@ msgstr "Ändere dein Profil"
msgid "Open on {0}"
igalic (Gemigreerd van github.com) reageerde 5 jaren geleden

"abonieren"

"abonieren"
igalic (Gemigreerd van github.com) reageerde 5 jaren geleden

"abbestellen"

"abbestellen"
elegaanz (Gemigreerd van github.com) beoordeeld 5 jaren geleden
po/plume/de.po
elegaanz (Gemigreerd van github.com) reageerde 5 jaren geleden

Yes, these strings have probably been automatically translated by GetText… 😕 I will edit them.

Yes, these strings have probably been automatically translated by GetText… :confused: I will edit them.
trinity-1686a beoordeeld 5 jaren geleden
trinity-1686a heeft een reactie achtergelaten
Eigenaar

(there are still 7 times the word "follow" and it's derivative in translations, so I believe it must not be gone everywhere, but this is not the main point of this pr)

(there are still 7 times the word "follow" and it's derivative in translations, so I believe it must not be gone everywhere, but this is not the main point of this pr)
elegaanz reageerde 5 jaren geleden (Gemigreerd van github.com)

I replaced the other occurrences of "follow" while we are at it.

I replaced the other occurrences of "follow" while we are at it.
trinity-1686a heeft deze veranderingen 5 jaren geleden goedgekeurd
trinity-1686a heeft een reactie achtergelaten
Eigenaar

👍

:+1:

Reviewers

trinity-1686a heeft deze veranderingen 5 jaren geleden goedgekeurd
De pull request is samengevoegd als e28371bbe4.
Je kunt ook command line instructies bekijken.

Stap 1:

Vanuit het project, check een branch uit en test de veranderingen.
git checkout -b follows-page master
git pull origin follows-page

Stap 2:

Voeg de wijzigingen samen en update ze op Forgejo.
git checkout master
git merge --no-ff follows-page
git push origin master
Log in om deel te nemen aan deze discussie.
Reviewers
Beoordeling aanvragen
Geen beoordelaars
trinity-1686a
Labels
Labels toepassen
Verwijder labels   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
Geen label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Mijlpaal
Stel mijlpaal in
Verwijder mijlpaal
Geen items
Geen mijlpaal
Toegewezen aan
Gebruikers toewijzen
Verwijder toegewezen aan
Niet toegewezen
2 deelnemers
Notificaties
Vervaldatum
De deadline is ongeldig of buiten bereik. Gebruik het formaat 'jjjj-mm-dd'.

Geen vervaldatum ingesteld.

Afhankelijkheden

Geen afhankelijkheden ingesteld.

Referentie: Plume/Plume#444
Schrijf Voorbeeld
Laden…
Annuleren
Opslaan
Er is nog geen inhoud.
Verwijder branch 'follows-page'

Het verwijderen van een branch is permanent. Het KAN NIET ongedaan gemaakt worden. Wil je toch doorgaan?

Nee
Ja