Plume
/
Plume
8
16
Fork 22
Código Issues 174 Pull requests 8 Versões 8 Wiki Atividade

Etiquetas Marcos

Add a page listing people someone follows #444

Merge aplicado
elegaanz aplicou merge dos 5 commits de follows-page em master 5 anos atrás
Conversação 2 Commits 5 Arquivos alterados 24
elegaanz comentou 5 anos atrás (Migrado de github.com)

Nothing exceptional, the layout is the same as the followers page.

Fixes #325

Nothing exceptional, the layout is the same as the followers page. Fixes #325
codecov[bot] comentou 5 anos atrás (Migrado de github.com)

Codecov Report

Merging #444 into master will increase coverage by 0.18%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
+ Coverage   25.58%   25.76%   +0.18%     
==========================================
  Files          63       63              
  Lines        6254     6477     +223     
==========================================
+ Hits         1600     1669      +69     
- Misses       4654     4808     +154
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/444?src=pr&el=h1) Report > Merging [#444](https://codecov.io/gh/Plume-org/Plume/pull/444?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/576a4ed49946545af1e2ef8db5058f840c05c8df?src=pr&el=desc) will **increase** coverage by `0.18%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #444 +/- ## ========================================== + Coverage 25.58% 25.76% +0.18% ========================================== Files 63 63 Lines 6254 6477 +223 ========================================== + Hits 1600 1669 +69 - Misses 4654 4808 +154 ```
trinity-1686a revisou 5 anos atrás
trinity-1686a deixou um comentário
Proprietário

👍

:+1:
igalic (Migrado de github.com) revisou 5 anos atrás
igalic (Migrado de github.com) deixou um comentário

words are hard…

words are hard…
plume-models/src/users.rs
@ -580,0 +586,4 @@
.map_err(Error::from)
}
pub fn get_followed_page(&self, conn: &Connection, (min, max): (i32, i32)) -> Result<Vec<User>> {
igalic (Migrado de github.com) comentou 5 anos atrás

n.b.: many people on the fediverse are not happy with the "clout" that comes from these numbers

do we offer an option to disable it?

i would also suggest considering "subscribe" instead of "follow".
it fits better with a blog, and has slightly less of a cult meaning

n.b.: many people on the fediverse are not happy with the "clout" that comes from these numbers do we offer an option to disable it? i would also suggest considering "subscribe" instead of "follow". it fits better with a blog, and has slightly less of a cult meaning
elegaanz (Migrado de github.com) revisou 5 anos atrás
plume-models/src/users.rs
@ -580,0 +586,4 @@
.map_err(Error::from)
}
pub fn get_followed_page(&self, conn: &Connection, (min, max): (i32, i32)) -> Result<Vec<User>> {
elegaanz (Migrado de github.com) comentou 5 anos atrás

These numbers are not currently displayed in the UI, we only use this function to know how many pages listing followers/followed we need. If we display them one day, I totally agree that we should be able to hide them (maybe even hide them by default?), or that they should only be shown for your own profile.

And I agree on "follow"/"subscribe" too, I will change it. 🙂

These numbers are not currently displayed in the UI, we only use this function to know how many pages listing followers/followed we need. If we display them one day, I totally agree that we should be able to hide them (maybe even hide them by default?), or that they should only be shown for your own profile. And I agree on "follow"/"subscribe" too, I will change it. :slightly_smiling_face:
igalic (Migrado de github.com) revisou 5 anos atrás
igalic (Migrado de github.com) deixou um comentário

🇩🇪 / 🇦🇹

🇩🇪 / 🇦🇹
po/plume/de.po
igalic (Migrado de github.com) comentou 5 anos atrás

not quite… "Abonoment" would be a better translation.

not quite… "Abonoment" would be a better translation.
igalic (Migrado de github.com) comentou 5 anos atrás

"Abonomenten"

"Abonomenten"
po/plume/de.po
@ -338,15 +341,19 @@ msgstr "Ändere dein Profil"
msgid "Open on {0}"
igalic (Migrado de github.com) comentou 5 anos atrás

"abonieren"

"abonieren"
igalic (Migrado de github.com) comentou 5 anos atrás

"abbestellen"

"abbestellen"
elegaanz (Migrado de github.com) revisou 5 anos atrás
po/plume/de.po
elegaanz (Migrado de github.com) comentou 5 anos atrás

Yes, these strings have probably been automatically translated by GetText… 😕 I will edit them.

Yes, these strings have probably been automatically translated by GetText… :confused: I will edit them.
trinity-1686a revisou 5 anos atrás
trinity-1686a deixou um comentário
Proprietário

(there are still 7 times the word "follow" and it's derivative in translations, so I believe it must not be gone everywhere, but this is not the main point of this pr)

(there are still 7 times the word "follow" and it's derivative in translations, so I believe it must not be gone everywhere, but this is not the main point of this pr)
elegaanz comentou 5 anos atrás (Migrado de github.com)

I replaced the other occurrences of "follow" while we are at it.

I replaced the other occurrences of "follow" while we are at it.
trinity-1686a aprovou estas alterações 5 anos atrás
trinity-1686a deixou um comentário
Proprietário

👍

:+1:

Revisores

trinity-1686a aprovou estas alterações 5 anos atrás
O pull request teve merge aplicado como e28371bbe4.
Você também pode ver as instruções para a linha de comandos.

Passo 1:

No repositório do seu projeto, crie um novo branch e teste as alterações.
git checkout -b follows-page master
git pull origin follows-page

Passo 2:

Faça merge das alterações e atualize no Forgejo.
git checkout master
git merge --no-ff follows-page
git push origin master
Acesse para participar desta conversação.
Revisores
Solicitar revisão
Sem revisor
trinity-1686a
Etiquetas
Aplicar etiquetas
Limpar etiquetas   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
Sem etiqueta
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Marco
Definir marco
Limpar marco
Nenhum item
Sem marco
Responsáveis
Atribuir usuários
Limpar responsáveis
Sem responsável
2 participante(s)
Notificações
Data limite
A data limite é inválida ou está fora do intervalo. Por favor, use o formato 'dd/mm/aaaa'.

Data limite não informada.

Dependências

Nenhuma dependência definida.

Referência: Plume/Plume#444
Escrever Pré-visualização
Carregando…
Cancelar
Salvar
Ainda não há conteúdo.
Excluir Branch 'follows-page'

A exclusão de um branch é permanente. Isto NÃO PODERÁ ser desfeito. Continuar?

Não
Sim