Plume
/
Plume
8
16
派生 22
代码 工单 174 合并请求 8 版本发布 8 百科 动态

标签 里程碑

Add a page listing people someone follows #444

已合并
elegaanz 于 5 年前 将 5 次代码提交从 follows-page 合并至 master
对话内容 2 代码提交 5 文件变动 24
elegaanz 评论于 5 年前 (从 github.com 迁移)

Nothing exceptional, the layout is the same as the followers page.

Fixes #325

Nothing exceptional, the layout is the same as the followers page. Fixes #325
codecov[bot] 评论于 5 年前 (从 github.com 迁移)

Codecov Report

Merging #444 into master will increase coverage by 0.18%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
+ Coverage   25.58%   25.76%   +0.18%     
==========================================
  Files          63       63              
  Lines        6254     6477     +223     
==========================================
+ Hits         1600     1669      +69     
- Misses       4654     4808     +154
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/444?src=pr&el=h1) Report > Merging [#444](https://codecov.io/gh/Plume-org/Plume/pull/444?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/576a4ed49946545af1e2ef8db5058f840c05c8df?src=pr&el=desc) will **increase** coverage by `0.18%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #444 +/- ## ========================================== + Coverage 25.58% 25.76% +0.18% ========================================== Files 63 63 Lines 6254 6477 +223 ========================================== + Hits 1600 1669 +69 - Misses 4654 4808 +154 ```
trinity-1686a 评审于 5 年前
trinity-1686a 留下了一条评论
所有者

👍

:+1:
igalic (从 github.com 迁移) 评审于 5 年前
igalic (从 github.com 迁移) 留下了一条评论

words are hard…

words are hard…
plume-models/src/users.rs
@ -580,0 +586,4 @@
.map_err(Error::from)
}
pub fn get_followed_page(&self, conn: &Connection, (min, max): (i32, i32)) -> Result<Vec<User>> {
igalic (从 github.com 迁移) 评论于 5 年前

n.b.: many people on the fediverse are not happy with the "clout" that comes from these numbers

do we offer an option to disable it?

i would also suggest considering "subscribe" instead of "follow".
it fits better with a blog, and has slightly less of a cult meaning

n.b.: many people on the fediverse are not happy with the "clout" that comes from these numbers do we offer an option to disable it? i would also suggest considering "subscribe" instead of "follow". it fits better with a blog, and has slightly less of a cult meaning
elegaanz (从 github.com 迁移) 评审于 5 年前
plume-models/src/users.rs
@ -580,0 +586,4 @@
.map_err(Error::from)
}
pub fn get_followed_page(&self, conn: &Connection, (min, max): (i32, i32)) -> Result<Vec<User>> {
elegaanz (从 github.com 迁移) 评论于 5 年前

These numbers are not currently displayed in the UI, we only use this function to know how many pages listing followers/followed we need. If we display them one day, I totally agree that we should be able to hide them (maybe even hide them by default?), or that they should only be shown for your own profile.

And I agree on "follow"/"subscribe" too, I will change it. 🙂

These numbers are not currently displayed in the UI, we only use this function to know how many pages listing followers/followed we need. If we display them one day, I totally agree that we should be able to hide them (maybe even hide them by default?), or that they should only be shown for your own profile. And I agree on "follow"/"subscribe" too, I will change it. :slightly_smiling_face:
igalic (从 github.com 迁移) 评审于 5 年前
igalic (从 github.com 迁移) 留下了一条评论

🇩🇪 / 🇦🇹

🇩🇪 / 🇦🇹
po/plume/de.po
igalic (从 github.com 迁移) 评论于 5 年前

not quite… "Abonoment" would be a better translation.

not quite… "Abonoment" would be a better translation.
igalic (从 github.com 迁移) 评论于 5 年前

"Abonomenten"

"Abonomenten"
po/plume/de.po
@ -338,15 +341,19 @@ msgstr "Ändere dein Profil"
msgid "Open on {0}"
igalic (从 github.com 迁移) 评论于 5 年前

"abonieren"

"abonieren"
igalic (从 github.com 迁移) 评论于 5 年前

"abbestellen"

"abbestellen"
elegaanz (从 github.com 迁移) 评审于 5 年前
po/plume/de.po
elegaanz (从 github.com 迁移) 评论于 5 年前

Yes, these strings have probably been automatically translated by GetText… 😕 I will edit them.

Yes, these strings have probably been automatically translated by GetText… :confused: I will edit them.
trinity-1686a 评审于 5 年前
trinity-1686a 留下了一条评论
所有者

(there are still 7 times the word "follow" and it's derivative in translations, so I believe it must not be gone everywhere, but this is not the main point of this pr)

(there are still 7 times the word "follow" and it's derivative in translations, so I believe it must not be gone everywhere, but this is not the main point of this pr)
elegaanz 评论于 5 年前 (从 github.com 迁移)

I replaced the other occurrences of "follow" while we are at it.

I replaced the other occurrences of "follow" while we are at it.
trinity-1686a 于 5 年前 批准此合并请求
trinity-1686a 留下了一条评论
所有者

👍

:+1:

评审人

trinity-1686a 于 5 年前 批准此合并请求
该合并请求已作为 e28371bbe4 被合并。
你也可以查看 命令行指令

第一步:

从你的仓库中签出一个新的分支并测试变更。
git checkout -b follows-page master
git pull origin follows-page

第二步：

合并变更并更新到 Forgejo 上
git checkout master
git merge --no-ff follows-page
git push origin master
登录 并参与到对话中。
评审人
请求审核
无审核者
trinity-1686a
标签
添加标签
清除选中标签   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
未选择标签
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
里程碑
设置里程碑
取消选中里程碑
无可选项
未选择里程碑
指派成员
指派用户
取消指派成员
未指派成员
2 名参与者
通知
到期时间
到期日期无效或超出范围。请使用 'yyyy-mm-dd' 格式。

未设置到期时间。

依赖工单

没有设置依赖项。

参考：Plume/Plume#444
撰写 预览
正在加载...
取消
保存
这个人很懒，什么都没留下。
删除分支 'follows-page'

删除分支是永久的。此操作 无法 撤销，继续？

取消操作
确认操作